Commit ffef30ae authored by paul luse's avatar paul luse Committed by Tomasz Zawadzki
Browse files

modules/accel_dsa: update IDXD references to DSA where it makes sense 



IDXD has always been used everywhere but technically it stands for
the driver, not the HW (Intel Data Streaming Accelerator Driver)
where the X comes from "Streaming Accelerator" somehow.  Anyway, the
underlying hardware is just DSA.  It doesn't matter much now but
upcoming patches will add support for a new HW accelerator called
the Intel In-Memory Analytics Accelerator which we'll call IAA and
it will use the same (mostly) device driver (IDXD) as DSA.  So, calling
the HW what it is will lessen confusion when adding IAA support.

This patch just does renaming for the accel_fw module and associated
files (RPC, etc).

Signed-off-by: default avatarpaul luse <paul.e.luse@intel.com>
Change-Id: Ib3b1f982cc60359ecfea5dbcbeeb33e4d69aee6a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11984


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 07e31b02

CHANGELOG.md

+6 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ in multipath mode. 
A new option `disable_auto_failback` was added to the `bdev_nvme_set_options` RPC to disable

automatic failback.



### idxd

### idxd / dsa



A new parameter `flags` was added to all low level submission and preparation

APIs to enable the caller to pass operation flags per the DSA specification.
@@ -40,6 +40,11 @@ APIs to enable the caller to pass operation flags per the DSA specification. 
A new flag 'SPDK_IDXD_FLAG_PERSISTENT' was added to let DSA know that

the destination is persistent.



The RPC `idxd_scan_accel_engine` has been renamed to `dsa_scan_accel_engine`



Many HW related structs/functions with the name `idxd` have been renamed `dsa`

to more accurately represent the HW they are associated with.



### accel_fw



A new parameter `flags` was added to accel API.

doc/accel_fw.md

+4 −2
Original line number Diff line number Diff line
@@ -72,10 +72,12 @@ RPC is provided, the framework is available and will use the software plug-in mo 


To use the IOAT engine, use the RPC [`ioat_scan_accel_engine`](https://spdk.io/doc/jsonrpc.html) before starting the application.



### IDXD Module {#accel_idxd}

### DSA Module {#accel_dsa}



The DSA module supports the DSA hardware and relies on the low level IDXD library.



To use the DSA engine, use the RPC

[`idxd_scan_accel_engine`](https://spdk.io/doc/jsonrpc.html). By default, this

[`dsa_scan_accel_engine`](https://spdk.io/doc/jsonrpc.html). By default, this

will attempt to load the SPDK user-space idxd driver. To use the built-in

kernel driver on Linux, add the `-k` parameter. See the next section for

details on using the kernel driver.

doc/jsonrpc.md

+4 −4
Original line number Diff line number Diff line
@@ -442,7 +442,7 @@ Example response: 
    "framework_monitor_context_switch",

    "spdk_kill_instance",

    "ioat_scan_accel_engine",

    "idxd_scan_accel_engine",

    "dsa_scan_accel_engine",

    "bdev_virtio_attach_controller",

    "bdev_virtio_scsi_get_devices",

    "bdev_virtio_detach_controller",
@@ -1493,9 +1493,9 @@ Example response: 


## Acceleration Framework Layer {#jsonrpc_components_accel_fw}



### idxd_scan_accel_engine {#rpc_idxd_scan_accel_engine}

### dsa_scan_accel_engine {#rpc_dsa_scan_accel_engine}



Set config and enable idxd accel engine offload.

Set config and enable dsa accel engine offload.

This feature is considered as experimental.



#### Parameters
@@ -1514,7 +1514,7 @@ Example request: 
    "config_kernel_mode": false

  },

  "jsonrpc": "2.0",

  "method": "idxd_scan_accel_engine",

  "method": "dsa_scan_accel_engine",

  "id": 1

}

~~~

include/spdk_internal/trace_defs.h

+3 −3
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ 
#define TRACE_GROUP_FTL		0x6

#define TRACE_GROUP_BLOBFS	0x7

#define TRACE_GROUP_NVMF_FC	0x8

#define TRACE_GROUP_IDXD	0x9

#define TRACE_GROUP_ACCEL_DSA	0x9

#define TRACE_GROUP_THREAD	0xA

#define TRACE_GROUP_NVME_PCIE	0xB
@@ -166,7 +166,7 @@ 
#define TRACE_NVME_PCIE_COMPLETE	SPDK_TPOINT_ID(TRACE_GROUP_NVME_PCIE, 0x1)



/* idxd trace definitions */

#define TRACE_IDXD_OP_SUBMIT	SPDK_TPOINT_ID(TRACE_GROUP_IDXD, 0x0)

#define TRACE_IDXD_OP_COMPLETE	SPDK_TPOINT_ID(TRACE_GROUP_IDXD, 0x1)

#define TRACE_ACCEL_DSA_OP_SUBMIT	SPDK_TPOINT_ID(TRACE_GROUP_ACCEL_DSA, 0x0)

#define TRACE_ACCEL_DSA_OP_COMPLETE	SPDK_TPOINT_ID(TRACE_GROUP_ACCEL_DSA, 0x1)



#endif /* SPDK_INTERNAL_TRACE_DEFS */

mk/spdk.lib_deps.mk

+1 −1
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ endif 


# module/accel

DEPDIRS-accel_ioat := log ioat thread jsonrpc rpc accel

DEPDIRS-accel_idxd := log idxd thread $(JSON_LIBS) accel trace

DEPDIRS-accel_dsa := log idxd thread $(JSON_LIBS) accel trace



# module/env_dpdk

DEPDIRS-env_dpdk_rpc := log $(JSON_LIBS)