Commit ff8a4251 authored by Maciej Szwed's avatar Maciej Szwed Committed by Tomasz Zawadzki
Browse files

nvmf: Return ACWU and NACWU values in indentify structures 



For ACWU we always set value 1 because bdev holds
information specific for namespace only. This value
actually does not matter because we also set NACWU
which makes ACWU irrelevant. We set ACWU because
NVMe specs requires ACWU != 0 if fused commands
are supported.

Signed-off-by: default avatarMaciej Szwed <maciej.szwed@intel.com>
Change-Id: Ida4357026d3b32677fc824b3cd878e7ad8ef2680

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477915


Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent c1373391

lib/nvmf/ctrlr.c

+1 −0
Original line number Diff line number Diff line
@@ -1626,6 +1626,7 @@ spdk_nvmf_ctrlr_identify_ctrlr(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_c 
	cdata->sgls.keyed_sgl = 1;

	cdata->sgls.sgl_offset = 1;

	cdata->fuses.compare_and_write = 0;

	cdata->acwu = 1;

	spdk_strcpy_pad(cdata->subnqn, subsystem->subnqn, sizeof(cdata->subnqn), '\0');



	SPDK_DEBUGLOG(SPDK_LOG_NVMF, "ctrlr data: maxcmd 0x%x\n", cdata->maxcmd);

lib/nvmf/ctrlr_bdev.c

+1 −0
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_da 
	nsdata->nuse = num_blocks;

	nsdata->nlbaf = 0;

	nsdata->flbas.format = 0;

	nsdata->nacwu = spdk_bdev_get_acwu(bdev);

	if (!dif_insert_or_strip) {

		nsdata->lbaf[0].ms = spdk_bdev_get_md_size(bdev);

		nsdata->lbaf[0].lbads = spdk_u32log2(spdk_bdev_get_block_size(bdev));