Commit ff0dc8ce authored by Yankun Li's avatar Yankun Li Committed by Konrad Sztyber
Browse files

lib/reduce: Use memset instead of memcpy setting 0 



Change-Id: I5b03513f64ea2b1abe968b6f7564f51b93099879
Signed-off-by: default avatarYankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25411


Reviewed-by: default avatarGangCao <gang.cao@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
parent d1c46ed8

lib/reduce/reduce.c

+4 −5
Original line number Diff line number Diff line
@@ -1564,7 +1564,6 @@ static inline void 
_prepare_compress_chunk_copy_user_buffers(struct spdk_reduce_vol_request *req, bool zero_paddings)

{

	struct spdk_reduce_vol *vol = req->vol;

	char *padding_buffer = zero_paddings ? g_zero_buf : req->decomp_buf;

	uint64_t chunk_offset, ttl_len = 0;

	uint64_t remainder = 0;

	char *copy_offset = NULL;
@@ -1579,9 +1578,9 @@ _prepare_compress_chunk_copy_user_buffers(struct spdk_reduce_vol_request *req, b 


	if (chunk_offset) {

		ttl_len += chunk_offset * lbsize;

		/* copy_offset already points to padding buffer if zero_paddings=false */

		/* copy_offset already points to the correct buffer if zero_paddings=false */

		if (zero_paddings) {

			memcpy(copy_offset, padding_buffer, ttl_len);

			memset(copy_offset, 0, ttl_len);

		}

		copy_offset += ttl_len;

	}
@@ -1595,9 +1594,9 @@ _prepare_compress_chunk_copy_user_buffers(struct spdk_reduce_vol_request *req, b 


	remainder = vol->params.chunk_size - ttl_len;

	if (remainder) {

		/* copy_offset already points to padding buffer if zero_paddings=false */

		/* copy_offset already points to the correct buffer if zero_paddings=false */

		if (zero_paddings) {

			memcpy(copy_offset, padding_buffer + ttl_len, remainder);

			memset(copy_offset, 0, remainder);

		}

		ttl_len += remainder;

	}