Commit fc04b134 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

trace: increase SPDK_TRACE_MAX_LCORE to 1024



We limited this to 128 originally since that was aligned with the 128 max
lcores supported by DPDK on x86.

But 128 isn't a suitable maximum anymore. SPDK trace files are also dynamic
now, meaning we don't allocate trace buffers for unused lcores. There is a
small amount of space that we allocate per-lcore for thread names, but this
pales in comparison to the size of a typical trace buffer.

So bump the number to 1024. This will allocate an extra 14KB of data per
trace file ((1024 - 128) * 16B) for thread names, but each core's trace
buffer by default is 1MB so this seems like a minor amount of additional
overhead.

Fixes issue #3301.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I87e656fc7c8b2002e90d71f6eb11fb4699582f63
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22418


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 40681adc
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ struct spdk_trace_history {
	struct spdk_trace_entry		entries[0];
};

#define SPDK_TRACE_MAX_LCORE		128
#define SPDK_TRACE_MAX_LCORE		1024

struct spdk_trace_file {
	uint64_t			file_size;
+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ import tempfile

TSC_MAX = (1 << 64) - 1
UCHAR_MAX = (1 << 8) - 1
TRACE_MAX_LCORE = 128
TRACE_MAX_LCORE = 1024
TRACE_MAX_GROUP_ID = 16
TRACE_MAX_TPOINT_ID = TRACE_MAX_GROUP_ID * 64
TRACE_MAX_ARGS_COUNT = 8