Commit fb712988 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvmf: add const to nqn getters 



There is a warning triggered when holding ref to const obj and passing
to these getters.

Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I2c7b4ea0d325d84d66923fc524273ea44a3a311b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/997


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent c65d64a6

include/spdk/nvmf.h

+2 −2
Original line number Diff line number Diff line
@@ -558,7 +558,7 @@ struct spdk_nvmf_host *spdk_nvmf_subsystem_get_next_host(struct spdk_nvmf_subsys 
 *

 * \return NQN of host.

 */

const char *spdk_nvmf_host_get_nqn(struct spdk_nvmf_host *host);

const char *spdk_nvmf_host_get_nqn(const struct spdk_nvmf_host *host);



/**

 * Accept new connections on the address provided.
@@ -845,7 +845,7 @@ int spdk_nvmf_subsystem_set_mn(struct spdk_nvmf_subsystem *subsystem, const char 
 *

 * \return NQN of the specified subsystem.

 */

const char *spdk_nvmf_subsystem_get_nqn(struct spdk_nvmf_subsystem *subsystem);

const char *spdk_nvmf_subsystem_get_nqn(const struct spdk_nvmf_subsystem *subsystem);



/**

 * Get the type of the specified subsystem.

lib/nvmf/subsystem.c

+2 −2
Original line number Diff line number Diff line
@@ -727,7 +727,7 @@ spdk_nvmf_subsystem_get_next_host(struct spdk_nvmf_subsystem *subsystem, 
}



const char *

spdk_nvmf_host_get_nqn(struct spdk_nvmf_host *host)

spdk_nvmf_host_get_nqn(const struct spdk_nvmf_host *host)

{

	return host->nqn;

}
@@ -1318,7 +1318,7 @@ spdk_nvmf_subsystem_set_mn(struct spdk_nvmf_subsystem *subsystem, const char *mn 
}



const char *

spdk_nvmf_subsystem_get_nqn(struct spdk_nvmf_subsystem *subsystem)

spdk_nvmf_subsystem_get_nqn(const struct spdk_nvmf_subsystem *subsystem)

{

	return subsystem->subnqn;

}

test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ DEFINE_STUB(spdk_bdev_nvme_io_passthru, int, 
DEFINE_STUB_V(spdk_bdev_free_io, (struct spdk_bdev_io *bdev_io));



DEFINE_STUB(spdk_nvmf_subsystem_get_nqn, const char *,

	    (struct spdk_nvmf_subsystem *subsystem), NULL);

	    (const struct spdk_nvmf_subsystem *subsystem), NULL);



struct spdk_nvmf_ns *

spdk_nvmf_subsystem_get_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid)