Commit fa272c9b authored Feb 28, 2023 by Marcin Spiewak Committed by Tomasz Zawadzki Mar 03, 2023

lib/idxd: Removed SPDK_IDXD_FLAG_PERSISTENT flag



Removed SPDK_IDXD_FLAG_PERSISTENT flag and associated code.

Change-Id: Ib4e038794792ae9866bdf344f1ec58dd04dbd483
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16986


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

parent 2903189c

include/spdk/idxd.h

+0 −5

Original line number	Diff line number	Diff line
		@@ -35,11 +35,6 @@ extern "C" {
		*/
		#define SPDK_IDXD_FLAG_NONTEMPORAL IDXD_FLAG_CACHE_CONTROL

		/* The following flag is optional and specifies that the destination is persistent memory. The
		* low level library will not set this flag.
		*/
		#define SPDK_IDXD_FLAG_PERSISTENT IDXD_FLAG_DEST_STEERING_TAG

		/**
		* Opaque handle for a single IDXD channel.
		*/

lib/idxd/idxd.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -630,15 +630,8 @@ _idxd_flush_batch(struct spdk_idxd_io_channel *chan)
		static inline void
		_update_write_flags(struct spdk_idxd_io_channel chan, struct idxd_hw_desc desc)
		{
		if (desc->flags & SPDK_IDXD_FLAG_PERSISTENT) {
		/* recent spec changes require a different set of flags for PMEM writes */
		desc->flags &= ~IDXD_FLAG_DEST_STEERING_TAG;
		desc->flags &= ~IDXD_FLAG_CACHE_CONTROL;
		desc->flags \|= IDXD_FLAG_DEST_READBACK;
		} else {
		desc->flags ^= IDXD_FLAG_CACHE_CONTROL;
		}
		}

		int
		spdk_idxd_submit_copy(struct spdk_idxd_io_channel *chan,