Commit f924c94b authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Tomasz Zawadzki
Browse files

test: Shellcheck - correct rule: Use grep -q... 



Correct shellcheck rule SC2143: Use grep -q instead
of comparing output with [ -n .. ].

Change-Id: Ibfce9633eda332c64b27914b2fde51c9a26ff7f3
Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/474957


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 94ec4785

scripts/check_format.sh

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ if hash shellcheck 2>/dev/null; then 
	SHCK_EXCLUDE="SC1083,SC2002,\

SC2010,SC2012,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\

SC2097,SC2098,SC2119,SC2120,SC2128,\

SC2129,SC2143"

SC2129"

	# SPDK fails some error checks which have been deprecated in later versions of shellcheck.

	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.

test/nvmf/common.sh

+1 −1
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ function check_ip_is_soft_roce() 
	IP=$1

	if hash rxe_cfg; then

		dev=$(ip -4 -o addr show | grep $IP | cut -d" " -f2)

		if [ -z $(rxe_cfg | grep $dev | awk '{print $4}' | grep "rxe") ]; then

		if (rxe_cfg | grep $dev | awk '{print $4}' | grep -q "rxe"); then

			return 1

		else

			return 0