Commit f74b33ad authored by Chunyang Hui's avatar Chunyang Hui Committed by Jim Harris
Browse files

Opal: Small fixes 



1. Log level change to info when checking support
2. Delete new lines
3. Enlarge the timeout seconds to 10min for revert
   TPer as it sometimes need 6-7min for this operation.

Change-Id: I1b7e32917bd99c859f1515b07f2530669418f0db
Signed-off-by: default avatarChunyang Hui <chunyang.hui@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468915


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
parent 6b05c109

lib/nvme/nvme_opal.c

+2 −3
Original line number Diff line number Diff line
@@ -882,7 +882,7 @@ opal_discovery0_end(struct spdk_opal_dev *dev) 
			supported = true;

			break;

		default:

			SPDK_NOTICELOG("Unknow feature code: %d\n", feature_code);

			SPDK_INFOLOG(SPDK_LOG_OPAL, "Unknow feature code: %d\n", feature_code);

		}

		cpos += body->tper.length + 4;

	}
@@ -893,7 +893,7 @@ opal_discovery0_end(struct spdk_opal_dev *dev) 
	}



	if (single_user == false) {

		SPDK_NOTICELOG("Single User Mode Not Supported\n");

		SPDK_INFOLOG(SPDK_LOG_OPAL, "Single User Mode Not Supported\n");

	}



	if (found_com_id == false) {
@@ -1063,7 +1063,6 @@ opal_start_generic_session(struct spdk_opal_dev *dev, 
	return opal_finalize_and_send(dev, 1, opal_start_session_cb, NULL);

}





static int

opal_start_anybody_adminsp_session(struct spdk_opal_dev *dev)

{

lib/nvme/nvme_opal_internal.h

+1 −1
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ 
#define OPAL_UID_LENGTH			8

#define OPAL_MAX_LRS			8 /* minimum 8 defined by spec */



#define SPDK_OPAL_TPER_TIMEOUT		30 /* seconds */

#define SPDK_OPAL_TPER_TIMEOUT		600 /* seconds */



#define GENERIC_HOST_SESSION_NUM	0x69