Commit f71aa700 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

iscsi: remove unnecessary mutex 



target->mutex doesn't guard any data structure.

Change-Id: I07d75b43d0b016e3c6b56baab4b1707887ab019d
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/414362


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent feb7f2b3

lib/iscsi/iscsi.c

+0 −8
Original line number Diff line number Diff line
@@ -4582,10 +4582,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn, 
	/* configuration values */

	pthread_mutex_lock(&g_spdk_iscsi.mutex);



	if (target != NULL) {

		pthread_mutex_lock(&target->mutex);

	}



	sess->MaxConnections = g_spdk_iscsi.MaxConnectionsPerSession;

	sess->MaxOutstandingR2T = DEFAULT_MAXOUTSTANDINGR2T;
@@ -4599,10 +4595,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn, 
	sess->DataSequenceInOrder = DEFAULT_DATASEQUENCEINORDER;

	sess->ErrorRecoveryLevel = g_spdk_iscsi.ErrorRecoveryLevel;



	if (target != NULL) {

		pthread_mutex_unlock(&target->mutex);

	}



	pthread_mutex_unlock(&g_spdk_iscsi.mutex);



	sess->tag = conn->portal->group->tag;