Commit f6fa387f authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

vhost/nvme: remove pointless task NULL check 



task must be non-NULL in blk_unmap_complete_cb - it is retrieved from
child->parent, which is always set to a known good task in the only
call site.

Change-Id: I28dce62d4cb586311dc87f988c01aa0e03665e4d
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/408393


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 8e098e41

lib/vhost/vhost_nvme.c

+7 −8
Original line number Diff line number Diff line
@@ -343,7 +343,6 @@ blk_unmap_complete_cb(struct spdk_bdev_io *bdev_io, bool success, void *cb_arg) 
		spdk_bdev_free_io(bdev_io);

	}



	if (task) {

	task->num_children--;

	if (!success) {

		task->success = false;
@@ -351,7 +350,7 @@ blk_unmap_complete_cb(struct spdk_bdev_io *bdev_io, bool success, void *cb_arg) 
	if (!task->num_children) {

		blk_request_complete_cb(NULL, task->success, task);

	}

	}



	STAILQ_INSERT_TAIL(&nvme->free_tasks, child, stailq);

}