Commit f64fe6fe authored by Artur Paszkiewicz's avatar Artur Paszkiewicz Committed by Jim Harris
Browse files

bdev/lvol: remove _vbdev_lvol_examine_close_cb 



Remove _vbdev_lvol_examine_close_cb() because it is identical as the
code at the end of _vbdev_lvs_examine_finish().

Remove the INFOLOG message because it is redundant (there's an ERRLOG
just before) and inconsistent with the lvolerrno != 0 case, where there
is no such message.

Change-Id: I8488a8b5fcbaf1895f4953081d98bc13f82be221
Signed-off-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16941


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 03e2374c

module/bdev/lvol/vbdev_lvol.c

+1 −12
Original line number Diff line number Diff line
@@ -1325,15 +1325,6 @@ _vbdev_lvs_examine_failed(void *cb_arg, int lvserrno) 
	spdk_bdev_module_examine_done(&g_lvol_if);

}



static void

_vbdev_lvol_examine_close_cb(struct spdk_lvol_store *lvs)

{

	if (lvs->lvols_opened >= lvs->lvol_count) {

		SPDK_INFOLOG(vbdev_lvol, "Opening lvols finished\n");

		spdk_bdev_module_examine_done(&g_lvol_if);

	}

}



static void

_vbdev_lvs_examine_finish(void *cb_arg, struct spdk_lvol *lvol, int lvolerrno)

{
@@ -1350,9 +1341,7 @@ _vbdev_lvs_examine_finish(void *cb_arg, struct spdk_lvol *lvol, int lvolerrno) 
	if (_create_lvol_disk(lvol, false)) {

		SPDK_ERRLOG("Cannot create bdev for lvol %s\n", lvol->unique_id);

		lvs->lvol_count--;

		_vbdev_lvol_examine_close_cb(lvs);

		SPDK_INFOLOG(vbdev_lvol, "Opening lvol %s failed\n", lvol->unique_id);

		return;

		goto end;

	}



	lvs->lvols_opened++;