Commit f6109e23 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

rpc: return RPC internal error when unable to get log level string 



Change-Id: I403172e07946911c29e511c5954d862d6971bf0b
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/433834


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarPawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent c06daf9a

lib/log/rpc/log_rpc.c

+16 −5
Original line number Diff line number Diff line
@@ -151,16 +151,21 @@ spdk_rpc_get_log_print_level(struct spdk_jsonrpc_request *request, 
		return;

	}



	level = spdk_log_get_print_level();

	name = _get_log_level_name(level);

	if (name == NULL) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,

						 "Internal error");

		return;

	}



	w = spdk_jsonrpc_begin_result(request);

	if (w == NULL) {

		return;

	}



	level = spdk_log_get_print_level();

	name = _get_log_level_name(level);

	spdk_json_write_string(w, name);





	spdk_jsonrpc_end_result(request, w);

}

SPDK_RPC_REGISTER("get_log_print_level", spdk_rpc_get_log_print_level,
@@ -219,13 +224,19 @@ spdk_rpc_get_log_level(struct spdk_jsonrpc_request *request, 
		return;

	}



	level = spdk_log_get_level();

	name = _get_log_level_name(level);

	if (name == NULL) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,

						 "Internal error");

		return;

	}



	w = spdk_jsonrpc_begin_result(request);

	if (w == NULL) {

		return;

	}



	level = spdk_log_get_level();

	name = _get_log_level_name(level);

	spdk_json_write_string(w, name);



	spdk_jsonrpc_end_result(request, w);