bdev: Added functions allowing logical volume store rename. (f5e590c8) · Commits · Public Repositories / spdk

include/spdk/lvol.h

+11 −0

Original line number	Diff line number	Diff line
		@@ -113,6 +113,17 @@ typedef void (spdk_lvol_op_complete)(void cb_arg, int lvolerrno);
		int spdk_lvs_init(struct spdk_bs_dev bs_dev, struct spdk_lvs_opts o,
		spdk_lvs_op_with_handle_complete cb_fn, void *cb_arg);

		/**
		* \brief Renames given lvolstore.
		*
		* \param lvs Pointer to lvolstore
		* \param new_name New name of lvs
		* \param cb_fn Completion callback
		* \param cb_arg Completion callback custom arguments
		*/
		void spdk_lvs_rename(struct spdk_lvol_store lvs, const char new_name,
		spdk_lvs_op_complete cb_fn, void *cb_arg);

		/**
		* \brief Unloads lvolstore
		*

include/spdk_internal/lvolstore.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -45,6 +45,8 @@
		struct spdk_lvs_req {
		spdk_lvs_op_complete cb_fn;
		void *cb_arg;
		struct spdk_lvol_store *lvol_store;
		int lvserrno;
		};

		struct spdk_lvol_req {
		@@ -89,6 +91,7 @@ struct spdk_lvol_store {
		bool on_list;
		TAILQ_ENTRY(spdk_lvol_store) link;
		char name[SPDK_LVS_NAME_MAX];
		char new_name[SPDK_LVS_NAME_MAX];
		};

		struct spdk_lvol {

lib/bdev/lvol/vbdev_lvol.c

+47 −0

Original line number	Diff line number	Diff line
		@@ -252,6 +252,53 @@ vbdev_lvs_create(struct spdk_bdev base_bdev, const char name, uint32_t cluster
		return 0;
		}

		static void
		_vbdev_lvs_rename_cb(void *cb_arg, int lvserrno)
		{
		struct spdk_lvs_req *req = cb_arg;
		struct spdk_lvol *tmp;

		if (lvserrno != 0) {
		SPDK_INFOLOG(SPDK_LOG_VBDEV_LVOL, "Lvol store rename failed\n");
		} else {
		TAILQ_FOREACH(tmp, &req->lvol_store->lvols, link) {
		/* We have to pass current lvol name, since only lvs name changed */
		_vbdev_lvol_change_bdev_alias(tmp, tmp->name);
		}
		}

		req->cb_fn(req->cb_arg, lvserrno);
		free(req);
		}

		void
		vbdev_lvs_rename(struct spdk_lvol_store lvs, const char new_lvs_name,
		spdk_lvs_op_complete cb_fn, void *cb_arg)
		{
		struct lvol_store_bdev *lvs_bdev;

		struct spdk_lvs_req *req;

		lvs_bdev = vbdev_get_lvs_bdev_by_lvs(lvs);
		if (!lvs_bdev) {
		SPDK_ERRLOG("No such lvol store found\n");
		cb_fn(cb_arg, -ENODEV);
		return;
		}

		req = calloc(1, sizeof(*req));
		if (!req) {
		SPDK_ERRLOG("Cannot alloc memory for vbdev lvol store request pointer\n");
		cb_fn(cb_arg, -ENOMEM);
		return;
		}
		req->cb_fn = cb_fn;
		req->cb_arg = cb_arg;
		req->lvol_store = lvs;

		spdk_lvs_rename(lvs, new_lvs_name, _vbdev_lvs_rename_cb, req);
		}

		static void
		_vbdev_lvs_remove_cb(void *cb_arg, int lvserrno)
		{

lib/bdev/lvol/vbdev_lvol.h

+11 −0

Original line number	Diff line number	Diff line
		@@ -60,6 +60,17 @@ int vbdev_lvol_resize(char name, size_t sz, spdk_lvol_op_complete cb_fn, void
		void vbdev_lvol_rename(struct spdk_lvol lvol, const char new_lvol_name,
		spdk_lvol_op_complete cb_fn, void *cb_arg);

		/**
		* \brief Renames given lvolstore.
		*
		* \param lvs Pointer to lvolstore
		* \param new_name New name of lvs
		* \param cb_fn Completion callback
		* \param cb_arg Completion callback custom arguments
		*/
		void vbdev_lvs_rename(struct spdk_lvol_store lvs, const char new_lvs_name,
		spdk_lvs_op_complete cb_fn, void *cb_arg);

		/**
		* \brief Search for handle lvolstore
		* \param uuid_str UUID of lvolstore

lib/bdev/lvol/vbdev_lvol_rpc.c

+76 −0

Original line number	Diff line number	Diff line
		@@ -168,6 +168,82 @@ invalid:
		}
		SPDK_RPC_REGISTER("construct_lvol_store", spdk_rpc_construct_lvol_store)

		struct rpc_rename_lvol_store {
		char *old_name;
		char *new_name;
		};

		static void
		free_rpc_rename_lvol_store(struct rpc_rename_lvol_store *req)
		{
		free(req->old_name);
		free(req->new_name);
		}

		static const struct spdk_json_object_decoder rpc_rename_lvol_store_decoders[] = {
		{"old_name", offsetof(struct rpc_rename_lvol_store, old_name), spdk_json_decode_string},
		{"new_name", offsetof(struct rpc_rename_lvol_store, new_name), spdk_json_decode_string},
		};

		static void
		_spdk_rpc_rename_lvol_store_cb(void *cb_arg, int lvserrno)
		{
		struct spdk_json_write_ctx *w;
		struct spdk_jsonrpc_request *request = cb_arg;

		if (lvserrno != 0) {
		goto invalid;
		}

		w = spdk_jsonrpc_begin_result(request);
		if (w == NULL) {
		return;
		}

		spdk_json_write_bool(w, true);
		spdk_jsonrpc_end_result(request, w);
		return;

		invalid:
		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
		spdk_strerror(-lvserrno));
		}

		static void
		spdk_rpc_rename_lvol_store(struct spdk_jsonrpc_request *request,
		const struct spdk_json_val *params)
		{
		struct rpc_rename_lvol_store req = {};
		struct spdk_lvol_store *lvs;
		int rc;

		if (spdk_json_decode_object(params, rpc_rename_lvol_store_decoders,
		SPDK_COUNTOF(rpc_rename_lvol_store_decoders),
		&req)) {
		SPDK_INFOLOG(SPDK_LOG_LVOL_RPC, "spdk_json_decode_object failed\n");
		rc = -EINVAL;
		goto invalid;
		}

		lvs = vbdev_get_lvol_store_by_name(req.old_name);
		if (lvs == NULL) {
		SPDK_INFOLOG(SPDK_LOG_LVOL_RPC, "no lvs existing for given name\n");
		rc = -ENOENT;
		goto invalid;
		}

		vbdev_lvs_rename(lvs, req.new_name, _spdk_rpc_rename_lvol_store_cb, request);

		free_rpc_rename_lvol_store(&req);

		return;

		invalid:
		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, spdk_strerror(-rc));
		free_rpc_rename_lvol_store(&req);
		}
		SPDK_RPC_REGISTER("rename_lvol_store", spdk_rpc_rename_lvol_store)

		struct rpc_destroy_lvol_store {
		char *uuid;
		char *lvs_name;