Commit f55717c3 authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

nvme/opal: remove the flush operation before each OPAL method 



It's not an error to send a security receive command before each
real OPAL related commands, but we don't need to do it.

Change-Id: I7628988df6ac097264db2137440f63db9e6e3660
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1127


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 0cd8b292

lib/nvme/nvme_opal.c

+0 −22
Original line number Diff line number Diff line
@@ -41,23 +41,6 @@ typedef int (*spdk_opal_cb)(struct spdk_opal_dev *dev, void *ctx); 


static int opal_parse_and_check_status(struct spdk_opal_dev *dev, void *data);



static int

opal_flush_response_buffer(struct spdk_opal_dev *dev)

{

	void *response = dev->resp;

	int ret = 0;



	ret = spdk_nvme_ctrlr_security_receive(dev->ctrlr, SPDK_SCSI_SECP_TCG, dev->comid,

					       0, response, IO_BUFFER_LENGTH);

	if (ret) {

		SPDK_ERRLOG("Security Receive Error on dev = %p\n", dev);

		return ret;

	}



	memset(response, 0, IO_BUFFER_LENGTH);

	return 0;

}



static int

opal_send_cmd(struct spdk_opal_dev *dev)

{
@@ -114,11 +97,6 @@ opal_send_recv(struct spdk_opal_dev *dev, spdk_opal_cb cb, void *data) 
{

	int ret;



	ret = opal_flush_response_buffer(dev);

	if (ret) {

		return ret;

	}



	ret = opal_send_cmd(dev);

	if (ret) {

		return ret;