Commit f53f8de6 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

util/net: fix spdk_net_get_address_string errno returned 



On missing sa or addr it should be EINVAL not EPERM.
While doing that adjust slightly return logic and return description.

Change-Id: Ib7199dab1be799ce63bb373bdae4d864ba40887c
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26050


Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent c9608af6

include/spdk/net.h

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ int spdk_net_get_interface_name(const char *ip, char *ifc, size_t len); 
 * \param addr string to put the address

 * \param len length of the the addr parameter

 *

 * \return 0 if successful, negative -errno otherwise

 * \return 0 on success, negative errno otherwise

 */

int spdk_net_get_address_string(struct sockaddr *sa, char *addr, size_t len);

lib/util/net.c

+4 −4
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ spdk_net_get_address_string(struct sockaddr *sa, char *addr, size_t len) 
	const char *result = NULL;



	if (sa == NULL || addr == NULL) {

		return -1;

		return -EINVAL;

	}



	switch (sa->sa_family) {
@@ -61,11 +61,11 @@ spdk_net_get_address_string(struct sockaddr *sa, char *addr, size_t len) 
		break;

	}



	if (result != NULL) {

		return 0;

	} else {

	if (result == NULL) {

		return -errno;

	}



	return 0;

}



bool