Commit f4d78f18 authored by Jim Harris's avatar Jim Harris
Browse files

blob: remove unused internal functions 



Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I67f1bf569a8a21f77729a30e933efd04ee05b86e

Reviewed-on: https://review.gerrithub.io/423957


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
parent a2794082

lib/blob/request.c

+0 −77
Original line number Diff line number Diff line
@@ -405,83 +405,6 @@ spdk_bs_batch_write_zeroes_dev(spdk_bs_batch_t *batch, 
				   &set->cb_args);

}



static void

spdk_bs_batch_blob_op_complete(void *arg, int bserrno)

{

	/* TODO: spdk_bs_batch_completion does not actually use the channel parameter -

	 *  just pass NULL here instead of getting the channel from the set cb_arg.

	 */

	spdk_bs_batch_completion(NULL, arg, bserrno);

}



void

spdk_bs_batch_read_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			void *payload, uint64_t offset, uint64_t length)

{

	struct spdk_bs_request_set	*set = (struct spdk_bs_request_set *)batch;

	struct spdk_bs_channel		*channel = set->channel;



	SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Reading %" PRIu64 " pages from offset %" PRIu64 "\n", length,

		      offset);



	set->u.batch.outstanding_ops++;

	spdk_blob_io_read(blob, spdk_io_channel_from_ctx(channel), payload, offset,

			  length, spdk_bs_batch_blob_op_complete, set);

}



void

spdk_bs_batch_write_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			 void *payload, uint64_t offset, uint64_t length)

{

	struct spdk_bs_request_set	*set = (struct spdk_bs_request_set *)batch;

	struct spdk_bs_channel		*channel = set->channel;



	SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Writing %" PRIu64 " pages from offset %" PRIu64 "\n", length,

		      offset);



	set->u.batch.outstanding_ops++;

	spdk_blob_io_write(blob, spdk_io_channel_from_ctx(channel), payload, offset,

			   length, spdk_bs_batch_blob_op_complete, set);

}



void

spdk_bs_batch_unmap_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			 uint64_t offset, uint64_t length)

{

	struct spdk_bs_request_set	*set = (struct spdk_bs_request_set *)batch;

	struct spdk_bs_channel		*channel = set->channel;



	SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Unmapping %" PRIu64 " pages from offset %" PRIu64 "\n", length,

		      offset);



	set->u.batch.outstanding_ops++;

	spdk_blob_io_unmap(blob, spdk_io_channel_from_ctx(channel), offset, length,

			   spdk_bs_batch_blob_op_complete, set);

}



void

spdk_bs_batch_write_zeroes_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

				uint64_t offset, uint64_t length)

{

	struct spdk_bs_request_set	*set = (struct spdk_bs_request_set *)batch;

	struct spdk_bs_channel		*channel = set->channel;



	SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Zeroing %" PRIu64 " pages from offset %" PRIu64 "\n", length,

		      offset);



	set->u.batch.outstanding_ops++;

	spdk_blob_io_write_zeroes(blob, spdk_io_channel_from_ctx(channel), offset, length,

				  spdk_bs_batch_blob_op_complete, set);

}



void

spdk_bs_batch_set_errno(spdk_bs_batch_t *batch, int bserrno)

{

	struct spdk_bs_request_set	*set = (struct spdk_bs_request_set *)batch;



	set->bserrno = bserrno;

}



void

spdk_bs_batch_close(spdk_bs_batch_t *batch)

{

lib/blob/request.h

+0 −14
Original line number Diff line number Diff line
@@ -202,20 +202,6 @@ void spdk_bs_batch_unmap_dev(spdk_bs_batch_t *batch, 
void spdk_bs_batch_write_zeroes_dev(spdk_bs_batch_t *batch,

				    uint64_t lba, uint32_t lba_count);



void spdk_bs_batch_read_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			     void *payload, uint64_t offset, uint64_t length);



void spdk_bs_batch_write_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			      void *payload, uint64_t offset, uint64_t length);



void spdk_bs_batch_unmap_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

			      uint64_t offset, uint64_t length);



void spdk_bs_batch_write_zeroes_blob(spdk_bs_batch_t *batch, struct spdk_blob *blob,

				     uint64_t offset, uint64_t length);



void spdk_bs_batch_set_errno(spdk_bs_batch_t *batch, int bserrno);



void spdk_bs_batch_close(spdk_bs_batch_t *batch);



spdk_bs_batch_t *spdk_bs_sequence_to_batch(spdk_bs_sequence_t *seq,