Commit f46b63e3 authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

bdev/delay: fix latency reporting. 



The arithmetic was backwards when computing the latency values to
report back to rpc calls like get_bdev. This caused reasonably sized
latency values to report back 0.

Change-Id: I85e22c9c8aa202a2ac1db7e7081f397800b151b8
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465168


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 8d6d26bd

lib/bdev/delay/vbdev_delay.c

+4 −4
Original line number Diff line number Diff line
@@ -374,13 +374,13 @@ _delay_write_conf_values(struct vbdev_delay *delay_node, struct spdk_json_write_ 
	spdk_json_write_named_string(w, "name", spdk_bdev_get_name(&delay_node->delay_bdev));

	spdk_json_write_named_string(w, "base_bdev_name", spdk_bdev_get_name(delay_node->base_bdev));

	spdk_json_write_named_int64(w, "avg_read_latency",

				    delay_node->average_read_latency_ticks / spdk_get_ticks_hz() * SPDK_SEC_TO_USEC);

				    delay_node->average_read_latency_ticks * SPDK_SEC_TO_USEC / spdk_get_ticks_hz());

	spdk_json_write_named_int64(w, "p99_read_latency",

				    delay_node->p99_read_latency_ticks / spdk_get_ticks_hz() * SPDK_SEC_TO_USEC);

				    delay_node->p99_read_latency_ticks * SPDK_SEC_TO_USEC / spdk_get_ticks_hz());

	spdk_json_write_named_int64(w, "avg_write_latency",

				    delay_node->average_write_latency_ticks / spdk_get_ticks_hz() * SPDK_SEC_TO_USEC);

				    delay_node->average_write_latency_ticks * SPDK_SEC_TO_USEC / spdk_get_ticks_hz());

	spdk_json_write_named_int64(w, "p99_write_latency",

				    delay_node->p99_write_latency_ticks / spdk_get_ticks_hz() * SPDK_SEC_TO_USEC);

				    delay_node->p99_write_latency_ticks * SPDK_SEC_TO_USEC / spdk_get_ticks_hz());

}



static int