Commit f42be9bb authored by Fedor Uporov's avatar Fedor Uporov Committed by Tomasz Zawadzki
Browse files

nvme-cuse-test: Fix nvme cuse test issue



The ./test/nvme/cuse/cuse.c failure could be reproduced by inserting
1 second sleep() between cuse devices updating function and cuse
devices verification function. The CU_ASSERT() failure happen because
spdk_nvme_ctrlr_is_active_ns() stub reports that first namespace is
inactive, but appropriate nvme0n1 file exist in /dev/spdk directory.
Currently the test passes because of delay between cuse devices
updating and device files refreshing in the /dev/spdk directory.

It was found, that nvme0n1 device is requested to create in case if
g_active_num_ns == 0. Make g_active_num_ns == 1 and add the
g_active_nsid_min == 0 to make it compatible with
cuse_nvme_ctrlr_update_namespaces() function.

Change-Id: I7d0389e976ee4954f414838eb45441c1bfd6cbe8
Signed-off-by: default avatarFedor Uporov <fuporov.vstack@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19049


Reviewed-by: default avatarJim Harris <jim.harris@gmail.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
parent 2fb672af
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ test_cuse_update(void)
	verify_devices(&ctrlr);

	g_active_num_ns = 0;
	g_active_nsid_min = 1;
	nvme_cuse_update(&ctrlr);
	verify_devices(&ctrlr);