Commit f27cbce4 authored by Maciej Szwed's avatar Maciej Szwed Committed by Darek Stojaczyk
Browse files

blobstore: Fix error path for snapshot creation 



In _spdk_bs_snapshot_origblob_sync_cpl function on error
path we should not close snapshot as it will be closed during
volume closing when bs_dev is being destroyed.
This issue was found in unit test (see next patch in series).

Signed-off-by: default avatarMaciej Szwed <maciej.szwed@intel.com>
Change-Id: I51c38d1f1f97b134679251b43109b1265e565a17
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455215


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent beefcd1a

lib/blob/blobstore.c

+1 −1
Original line number Diff line number Diff line
@@ -4499,7 +4499,7 @@ _spdk_bs_snapshot_origblob_sync_cpl(void *cb_arg, int bserrno) 


	if (bserrno != 0) {

		_spdk_bs_snapshot_swap_cluster_maps(newblob, origblob);

		_spdk_bs_clone_snapshot_newblob_cleanup(ctx, bserrno);

		_spdk_bs_clone_snapshot_origblob_cleanup(ctx, bserrno);

		return;

	}