Commit f1c79987 authored Oct 13, 2017 by Maciej Szwed Committed by Jim Harris Oct 13, 2017

lvol: return meaningful RPC errors



Signed-off-by: Maciej Szwed <maciej.szwed@intel.com>
Change-Id: If809fe808150498c7ad6797855fda3097e3b0c84

Reviewed-on: https://review.gerrithub.io/382470


Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 5bf109d5

lib/bdev/lvol/vbdev_lvol.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -558,13 +558,13 @@ vbdev_lvol_resize(char *name, size_t sz,
		lvol = vbdev_get_lvol_by_name(name);
		if (lvol == NULL) {
		SPDK_ERRLOG("lvol '%s' does not exist\n", name);
		return -1;
		return -ENODEV;
		}

		bdev = spdk_bdev_get_by_name(name);
		if (bdev == NULL) {
		SPDK_ERRLOG("bdev '%s' does not exist\n", name);
		return -1;
		return -ENODEV;
		}

		lvs = lvol->lvol_store;

lib/bdev/lvol/vbdev_lvol_rpc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -362,6 +362,7 @@ spdk_rpc_resize_lvol_bdev(struct spdk_jsonrpc_request *request,

		if (req.name == NULL) {
		SPDK_ERRLOG("missing name param\n");
		rc = -EINVAL;
		goto invalid;
		}

lib/lvol/lvol.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -342,6 +342,8 @@ _spdk_lvol_create_open_cb(void cb_arg, struct spdk_blob blob, int lvolerrno)
		lvol->name = spdk_sprintf_alloc("%s_%"PRIu64, uuid, (uint64_t)blob_id);
		if (!lvol->name) {
		spdk_bs_md_close_blob(&blob, _spdk_lvol_delete_blob_cb, lvol);
		SPDK_ERRLOG("Cannot alloc memory for lvol name\n");
		lvolerrno = -ENOMEM;
		goto invalid;
		}