Commit f0e6bbea authored by Wojciech Malikowski's avatar Wojciech Malikowski Committed by Jim Harris
Browse files

util/string: additional errno check after strtol() 



Without this check valgrind complains that we are using
uninitialized variable.

Change-Id: I5cb73d10e167004f6e4df9e3621ec3b35ec2448d
Signed-off-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/442519


Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 6903c407

lib/util/string.c

+2 −2
Original line number Diff line number Diff line
@@ -425,7 +425,7 @@ spdk_strtol(const char *nptr, int base) 


	val = strtol(nptr, &endptr, base);



	if (*endptr != '\0') {

	if (!errno && *endptr != '\0') {

		/* Non integer character was found. */

		return -EINVAL;

	} else if (errno == ERANGE && (val == LONG_MAX || val == LONG_MIN)) {
@@ -456,7 +456,7 @@ spdk_strtoll(const char *nptr, int base) 


	val = strtoll(nptr, &endptr, base);



	if (*endptr != '\0') {

	if (!errno && *endptr != '\0') {

		/* Non integer character was found. */

		return -EINVAL;

	} else if (errno == ERANGE && (val == LLONG_MAX || val == LLONG_MIN)) {