Commit f0748d19 authored by Mateusz Kozlowski's avatar Mateusz Kozlowski Committed by Konrad Sztyber
Browse files

lib/ftl: Enable chunk recovery for non-vss cache 



Non-vss NV cache uses P2L IO log. To recover chunk it reads
entires from the long and rebuilds P2L map.

Change-Id: I88bea8779dbd9f93e2897d53813439250da8627c
Signed-off-by: default avatarMariusz Barczak <Mariusz.Barczak@solidigmtechnology.com>
Signed-off-by: default avatarMateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19626


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
parent 6f50be26

lib/ftl/ftl_p2l_log.c

+21 −11
Original line number Diff line number Diff line
@@ -109,10 +109,10 @@ p2l_log_get_page(struct ftl_p2l_log *p2l) 
	ctrl->page.hdr.p2l_ckpt.seq_id = p2l->seq_id;

	ctrl->page.hdr.p2l_ckpt.count = 0;

	ctrl->page.hdr.p2l_ckpt.p2l_checksum = 0;

	ctrl->page.hdr.p2l_ckpt.idx = ctrl->entry_idx = p2l->entry_idx;



	/* Initialize the page control structure */

	ctrl->p2l = p2l;

	ctrl->entry_idx = p2l->entry_idx;

	TAILQ_INIT(&ctrl->ios);



	/* Increase P2L page index */
@@ -185,7 +185,9 @@ static void 
p2l_log_page_io(struct ftl_p2l_log *p2l, struct ftl_p2l_log_page_ctrl *ctrl)

{

	ctrl->page.hdr.p2l_ckpt.p2l_checksum = p2l_log_page_crc(&ctrl->page);

	ftl_md_persist_entries(p2l->md, ctrl->entry_idx, 1, &ctrl->page, NULL, p2l_log_page_io_cb,



	ftl_md_persist_entries(p2l->md, ctrl->page.hdr.p2l_ckpt.idx, 1, &ctrl->page, NULL,

			       p2l_log_page_io_cb,

			       ctrl, &ctrl->md_ctx);

}
@@ -363,7 +365,7 @@ ftl_p2l_log_read_is_next(struct ftl_p2l_log *p2l) 
		return false;

	}



	return p2l->entry_idx < p2l->entry_max;

	return p2l->read_ctx.idx < p2l->entry_max;

}



static bool
@@ -404,6 +406,20 @@ ftl_p2l_log_read_visit(struct ftl_p2l_log *p2l, struct ftl_p2l_log_page_ctrl *ct 
	uint64_t i, j;

	int rc = 0;



	ftl_bug(ctrl->entry_idx > p2l->entry_max);



	if (p2l->read_ctx.seq_id != page->hdr.p2l_ckpt.seq_id) {

		/* This page contains entires older than the owner's sequence ID */

		return;

	}



	if (ctrl->entry_idx != page->hdr.p2l_ckpt.idx) {

		FTL_ERRLOG(p2l->dev, "Read P2L IO Logs ERROR, invalid index, type %d\n",

			   p2l->md->region->type);

		p2l->read_ctx.result = -EINVAL;

		return;

	}



	if (crc != page->hdr.p2l_ckpt.p2l_checksum) {

		FTL_ERRLOG(p2l->dev, "Read P2L IO Log ERROR, CRC problem, type %d\n",

			   p2l->md->region->type);
@@ -418,11 +434,6 @@ ftl_p2l_log_read_visit(struct ftl_p2l_log *p2l, struct ftl_p2l_log_page_ctrl *ct 
		return;

	}



	if (p2l->read_ctx.seq_id != page->hdr.p2l_ckpt.seq_id) {

		/* This page contains entires older than the owner's sequence ID */

		return;

	}



	for (i = 0; i < page->hdr.p2l_ckpt.count; i++) {

		struct ftl_pl2_log_item *item = &page->items[i];
@@ -457,8 +468,6 @@ ftl_p2l_log_read_cb(int status, void *arg) 


	/* Release page control */

	ftl_mempool_put(p2l->page_pool, ctrl);

	ctrl = NULL;



	ftl_p2l_log_read_process(p2l);

}
@@ -477,7 +486,7 @@ ftl_p2l_log_read_process(struct ftl_p2l_log *p2l) 
		ctrl->entry_idx = p2l->read_ctx.idx++;



		/* Check if the index exceeding the buffer size */

		ftl_bug(p2l->entry_idx > p2l->entry_max);

		ftl_bug(p2l->read_ctx.idx > p2l->entry_max);



		p2l->read_ctx.qd++;

		ftl_md_read_entry(p2l->md, ctrl->entry_idx, &ctrl->page, NULL,
@@ -508,6 +517,7 @@ ftl_p2l_log_read(struct spdk_ftl_dev *dev, enum ftl_layout_region_type type, uin 
	p2l_log->read_ctx.cb_fn = cb_fn;

	p2l_log->read_ctx.cb_arg = cb_arg;

	p2l_log->read_ctx.cb_rd = cb_rd;

	p2l_log->read_ctx.seq_id = seq_id;



	ftl_p2l_log_read_process(p2l_log);

	if (ftl_p2l_log_read_is_qd(p2l_log)) {

lib/ftl/nvc/ftl_nvc_bdev_non_vss.c

+7 −0
Original line number Diff line number Diff line
@@ -138,6 +138,13 @@ static int 
recovery_chunk_recover_p2l_map_read_cb(struct spdk_ftl_dev *dev, void *cb_arg,

				       uint64_t lba, ftl_addr addr, uint64_t seq_id)

{

	struct ftl_mngt_process *mngt = cb_arg;

	struct recovery_chunk_ctx *ctx = ftl_mngt_get_process_ctx(mngt);

	struct ftl_nv_cache_chunk *chunk = ctx->chunk;



	ftl_nv_cache_chunk_set_addr(chunk, lba, addr);



	/* TODO We could stop scanning when getting all LBA within the chunk */

	return 0;

}

lib/ftl/utils/ftl_md.h

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ union ftl_md_vss { 
	struct {

		uint64_t	seq_id;

		uint32_t	p2l_checksum;

		uint32_t	reserved;

		uint32_t	idx;

		uint64_t	count;

	} p2l_ckpt;