Commit f0441b29 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

vmd: rename enable_vmd RPC to vmd_enable 



The new name is consistent with the naming scheme of
<subsystem>_<action> that all of our other RPCs use.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2cae7af5715add8eba26501cd192a6ac4884ec69
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13952


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarTom Nabarro <tom.nabarro@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent dc5b33d9

CHANGELOG.md

+3 −0
Original line number Diff line number Diff line
@@ -29,6 +29,9 @@ New options `psk_key` and `psk_identity` were added to the `sock_impl_set_option 
Added warning message for `bdev_rbd_create`, if it is used without -c.

`bdev_rbd_create()` API without specifying -c is deprecated and will be removed in future release.



Renamed `enable_vmd` RPC to `vmd_enable` to make it consistent with our naming scheme of

`<subsystem>_<action>`.  For now, the old name is still available, but is marked as deprecated.



### raid



Renamed the `raid5` module to `raid5f` to reflect that it is not a traditional

doc/jsonrpc.md

+2 −2
Original line number Diff line number Diff line
@@ -9963,7 +9963,7 @@ Example response: 
}

~~~



### enable_vmd {#rpc_enable_vmd}

### vmd_enable {#rpc_enable_vmd}



Enable VMD enumeration.
@@ -9982,7 +9982,7 @@ Example request: 
~~~json

{

  "jsonrpc": "2.0",

  "method": "enable_vmd",

  "method": "vmd_enable",

  "id": 1

}

~~~

doc/vmd.md

+2 −2
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ JSON config: 
    "subsystem": "vmd",

    "config": [

      {

        "method": "enable_vmd",

        "method": "vmd_enable",

        "params": {}

      }

    ]
@@ -95,7 +95,7 @@ JSON config: 
or use RPC call before framework starts e.g.

```

$ ./build/bin/spdk_tgt --wait_for_rpc

$ ./scripts/rpc.py enable_vmd

$ ./scripts/rpc.py vmd_enable

$ ./scripts/rpc.py framework_start_init

```

## Applications w/o application framework {#vmd_app}

module/event/subsystems/vmd/vmd.c

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ vmd_write_config_json(struct spdk_json_write_ctx *w) 


	if (g_enabled) {

		spdk_json_write_object_begin(w);

		spdk_json_write_named_string(w, "method", "enable_vmd");

		spdk_json_write_named_string(w, "method", "vmd_enable");

		spdk_json_write_named_object_begin(w, "params");

		spdk_json_write_object_end(w);

		spdk_json_write_object_end(w);

module/event/subsystems/vmd/vmd_rpc.c

+2 −2
Original line number Diff line number Diff line
@@ -18,5 +18,5 @@ rpc_vmd_enable(struct spdk_jsonrpc_request *request, const struct spdk_json_val 


	spdk_jsonrpc_send_bool_response(request, true);

}



SPDK_RPC_REGISTER("enable_vmd", rpc_vmd_enable, SPDK_RPC_STARTUP)
 
SPDK_RPC_REGISTER("vmd_enable", rpc_vmd_enable, SPDK_RPC_STARTUP)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(vmd_enable, enable_vmd)