Commit efef26e2 authored by Darek Stojaczyk's avatar Darek Stojaczyk
Browse files

Revert "bdev: temporarily allow bdev descriptors to be closed from any thread" 



Now that vhost closes bdev descriptors on the same thread
that opened them, we can reintroduce thread asserts into
the bdev layer.

This reverts commit 283abcb9.

Change-Id: I1acc455df0674b808ecf2fa58dffd183db6cf3c2
Signed-off-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459168


Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent feaf45d3

lib/bdev/bdev.c

+1 −4
Original line number Diff line number Diff line
@@ -4340,10 +4340,7 @@ spdk_bdev_close(struct spdk_bdev_desc *desc) 
	SPDK_DEBUGLOG(SPDK_LOG_BDEV, "Closing descriptor %p for bdev %s on thread %p\n", desc, bdev->name,

		      spdk_get_thread());



	if (desc->thread != spdk_get_thread()) {

		SPDK_ERRLOG("Descriptor %p for bdev %s closed on wrong thread (%p, expected %p)\n",

			    desc, bdev->name, spdk_get_thread(), desc->thread);

	}

	assert(desc->thread == spdk_get_thread());



	pthread_mutex_lock(&bdev->internal.mutex);