Commit efa06a2b authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Ben Walker
Browse files

bdev: remove free_request bdev backend function 



This callback was only used for freeing buffers, but the buffers are now
managed by the bdev core, so none of the free_request callbacks actually
do anything.

Change-Id: Icfe2e6169e829159dda5e3d75a27d8f040de07c6
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 78b83fd7

include/spdk/bdev.h

+0 −3
Original line number Diff line number Diff line
@@ -140,9 +140,6 @@ struct spdk_bdev_fn_table { 
	/** Process the IO. */

	void (*submit_request)(struct spdk_bdev_io *);



	/** Release buf for read command. */

	void (*free_request)(struct spdk_bdev_io *);



	/** Check if the block device supports a specific I/O type. */

	bool (*io_type_supported)(struct spdk_bdev *bdev, enum spdk_bdev_io_type);

};

lib/bdev/aio/blockdev_aio.c

+0 −5
Original line number Diff line number Diff line
@@ -273,10 +273,6 @@ static void blockdev_aio_submit_request(struct spdk_bdev_io *bdev_io) 
	}

}



static void blockdev_aio_free_request(struct spdk_bdev_io *bdev_io)

{

}



static bool

blockdev_aio_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)

{
@@ -296,7 +292,6 @@ static struct spdk_bdev_fn_table aio_fn_table = { 
	.destruct		= blockdev_aio_destruct,

	.check_io		= blockdev_aio_check_io,

	.submit_request		= blockdev_aio_submit_request,

	.free_request		= blockdev_aio_free_request,

	.io_type_supported	= blockdev_aio_io_type_supported,

};

lib/bdev/bdev.c

+1 −8
Original line number Diff line number Diff line
@@ -404,13 +404,6 @@ spdk_bdev_cleanup_pending_rbuf_io(struct spdk_bdev *bdev) 
	}

}



static void

spdk_bdev_io_free_request(struct spdk_bdev_io *bdev_io)

{

	bdev_io->bdev->fn_table->free_request(bdev_io);

	spdk_bdev_put_io(bdev_io);

}



static void

__submit_request(spdk_event_t event)

{
@@ -425,7 +418,7 @@ __submit_request(spdk_event_t event) 
		}

		bdev->fn_table->submit_request(bdev_io);

	} else {

		spdk_bdev_io_free_request(bdev_io);

		spdk_bdev_put_io(bdev_io);

	}

}

lib/bdev/malloc/blockdev_malloc.c

+0 −5
Original line number Diff line number Diff line
@@ -250,10 +250,6 @@ static void blockdev_malloc_submit_request(struct spdk_bdev_io *bdev_io) 
	}

}



static void blockdev_malloc_free_request(struct spdk_bdev_io *bdev_io)

{

}



static bool

blockdev_malloc_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)

{
@@ -274,7 +270,6 @@ static struct spdk_bdev_fn_table malloc_fn_table = { 
	.destruct		= blockdev_malloc_destruct,

	.check_io		= blockdev_malloc_check_io,

	.submit_request		= blockdev_malloc_submit_request,

	.free_request		= blockdev_malloc_free_request,

	.io_type_supported	= blockdev_malloc_io_type_supported,

};

lib/bdev/nvme/blockdev_nvme.c

+0 −5
Original line number Diff line number Diff line
@@ -272,10 +272,6 @@ static void blockdev_nvme_submit_request(struct spdk_bdev_io *bdev_io) 
	}

}



static void blockdev_nvme_free_request(struct spdk_bdev_io *bdev_io)

{

}



static bool

blockdev_nvme_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)

{
@@ -302,7 +298,6 @@ static struct spdk_bdev_fn_table nvmelib_fn_table = { 
	.destruct		= blockdev_nvme_destruct,

	.check_io		= blockdev_nvme_check_io,

	.submit_request		= blockdev_nvme_submit_request,

	.free_request		= blockdev_nvme_free_request,

	.io_type_supported	= blockdev_nvme_io_type_supported,

};