Commit ed7054e3 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

test/abi: remove checking exported API from headers



Having --header-dir parameter for abidiff seems to filter out
some of the API changes. As a result few were not
accounted for since the SPDK 23.05 code freeze.
Remove that parameter and add appropriate changes.

Suppressed changes in spdk_nvme_qpair since this is from nvme_internal.h
and transparent to the public API. Yet abidiff catches that once we remove
--header-dir option:
(113075be)nvme/rdma: Fix cq/qp destroy order
'struct spdk_nvme_qpair' changed:
  type size hasn't changed
  1 data member insertion:
    'uint8_t destroy_in_progress', at offset 103 (in bits) at nvme_internal.h:444:1


Increased libspdk_nvmf from 15.0 to 16.0 due to following commits:
(a711d629)lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init
'struct spdk_dif_ctx' changed:
  type size changed from 384 to 416 (in bits)
  1 data member insertion:
    'spdk_dif_pi_format dif_pi_format', at offset 160 (in bits) at dif.h:63:1


Increased libspdk_scsi from 6.0 to 7.0 due to following commit:
(a711d629)lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init
'struct spdk_dif_ctx' changed:
  type size changed from 384 to 416 (in bits)
  1 data member insertion:
    'spdk_dif_pi_format dif_pi_format', at offset 160 (in bits) at dif.h:63:1

Reported-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I6841f1620111ea2a4750160afdc8a78ebec2b210
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18435


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 9c6458d9
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

SO_VER := 15
SO_VER := 16
SO_MINOR := 0

C_SRCS = ctrlr.c ctrlr_discovery.c ctrlr_bdev.c \
+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

SO_VER := 6
SO_VER := 7
SO_MINOR := 0

C_SRCS = dev.c lun.c port.c scsi.c scsi_bdev.c scsi_pr.c scsi_rpc.c task.c
+3 −2
Original line number Diff line number Diff line
@@ -101,6 +101,9 @@ function confirm_abi_deps() {
	name = spdk_bs_opts
[suppress_type]
	name = spdk_app_opts
# To be removed, comes from nvme_internal.h
[suppress_type]
	name = spdk_nvme_qpair
EOF

	for object in "$libdir"/libspdk_*.so; do
@@ -114,8 +117,6 @@ EOF

		cmd_args=('abidiff'
			$source_abi_dir/$release/$so_file "$libdir/$so_file"
			'--headers-dir1' $source_abi_dir/$release/include
			'--headers-dir2' $rootdir/include
			'--leaf-changes-only' '--suppressions' $suppression_file)

		if ! output=$("${cmd_args[@]}" --stat); then