Commit ed56bffb authored by Maciej Szwed's avatar Maciej Szwed Committed by Ben Walker
Browse files

bdev/lvol: correct messages displayed on screen during tasting 



During tasting, if bdev is already claimed, we send errors on screen.
This is expected behavior so we should send only debug logs.

Signed-off-by: default avatarMaciej Szwed <maciej.szwed@intel.com>
Change-Id: Ic5766cfa3aed88099415991998381de69ee8b8b6

Reviewed-on: https://review.gerrithub.io/384229


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarPiotr Pelpliński <piotr.pelplinski@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 15c96c66

lib/bdev/bdev.c

+2 −1
Original line number Diff line number Diff line
@@ -1862,13 +1862,14 @@ spdk_bdev_open(struct spdk_bdev *bdev, bool write, spdk_bdev_remove_cb_t remove_ 


	desc = calloc(1, sizeof(*desc));

	if (desc == NULL) {

		SPDK_ERRLOG("Failed to allocate memory for bdev descriptor\n");

		return -ENOMEM;

	}



	pthread_mutex_lock(&bdev->mutex);



	if (write && bdev->claim_module) {

		SPDK_ERRLOG("failed, %s already claimed\n", bdev->name);

		SPDK_INFOLOG(SPDK_TRACE_BDEV, "Could not open %s - already claimed\n", bdev->name);

		free(desc);

		pthread_mutex_unlock(&bdev->mutex);

		return -EPERM;

lib/bdev/lvol/vbdev_lvol.c

+1 −1
Original line number Diff line number Diff line
@@ -872,7 +872,7 @@ vbdev_lvs_examine(struct spdk_bdev *bdev) 


	bs_dev = spdk_bdev_create_bs_dev(bdev, vbdev_lvs_hotremove_cb, bdev);

	if (!bs_dev) {

		SPDK_ERRLOG("Cannot create bs dev\n");

		SPDK_INFOLOG(SPDK_TRACE_VBDEV_LVOL, "Cannot create bs dev on %s\n", bdev->name);

		spdk_bdev_module_examine_done(SPDK_GET_BDEV_MODULE(lvol));

		free(req);

		return;

lib/blob/bdev/blob_bdev.c

+0 −1
Original line number Diff line number Diff line
@@ -210,7 +210,6 @@ spdk_bdev_create_bs_dev(struct spdk_bdev *bdev, spdk_bdev_remove_cb_t remove_cb, 


	rc = spdk_bdev_open(bdev, true, remove_cb, remove_ctx, &desc);

	if (rc != 0) {

		SPDK_ERRLOG("could not open bdev, error=%d\n", rc);

		free(b);

		return NULL;

	}