Commit ecfc43be authored by Tomasz Zawadzki's avatar Tomasz Zawadzki
Browse files

bdev/nvme: free avahi string after use 



String allocated in avahi_string_list_to_string()
was not freed after it was no longer needed.

Fixes #3122

Direct leak of 102 byte(s) in 2 object(s) allocated from:
    #0 0x7fc255cd92ef in malloc (/usr/lib64/libasan.so.8+0xd92ef) (BuildId: 6f17f87dc4c1aa9f9dde7c4856604c3a25ba4872)
    #1 0x7fc255bf5fb4 in avahi_malloc (/usr/lib64/libavahi-common.so.3+0x3fb4) (BuildId: e99b431894489a77a31921493f198df4850090e0)
    #2 0x7fc255bf6e74 in avahi_string_list_to_string (/usr/lib64/libavahi-common.so.3+0x4e74) (BuildId: e99b431894489a77a31921493f198df4850090e0)
    #3 0x4a3c93 in mdns_resolve_callback /home/tzawadzk/spdk/module/bdev/nvme/bdev_mdns_client.c:261
	....

Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ib0eae278d59152c97572531bef59efef36600f13
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20849


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
parent c47b9b42

module/bdev/nvme/bdev_mdns_client.c

+1 −0
Original line number Diff line number Diff line
@@ -276,6 +276,7 @@ mdns_resolve_callback( 
			     !!(flags & AVAHI_LOOKUP_RESULT_WIDE_AREA),

			     !!(flags & AVAHI_LOOKUP_RESULT_MULTICAST),

			     !!(flags & AVAHI_LOOKUP_RESULT_CACHED));

		avahi_free(t);



		ctx = get_mdns_discovery_ctx_by_svcname(type);

		if (!ctx) {