Commit ec415110 authored by Jim Harris's avatar Jim Harris Committed by Changpeng Liu
Browse files

bdev: avoid qos submission recursion 



_spdk_bdev_io_submit uses the bdev_io->internal.in_submit_request
flag to ensure we unwind in cases where the I/O is completed
inline (i.e. malloc or null bdevs).  But when an I/O gets queued
for QoS, and then we iterate through the queued I/O in
_spdk_bdev_qos_io_submit(), this flag was not getting set
when those I/O would get submitted to the underlying bdev.  This
would allow for _spdk_bdev_qos_io_submit recursion, resulting
in all kinds of different types of memory corruption.

Fixes #613.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I29263f4e7b2ead60f08b60474d210defa803348c

Reviewed-on: https://review.gerrithub.io/c/442127


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarLiang Yan <liang.z.yan@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarGangCao <gang.cao@intel.com>
parent bcebf365

lib/bdev/bdev.c

+2 −0
Original line number Diff line number Diff line
@@ -1410,7 +1410,9 @@ _spdk_bdev_qos_io_submit(struct spdk_bdev_channel *ch, struct spdk_bdev_qos *qos 
		TAILQ_REMOVE(&qos->queued, bdev_io, internal.link);

		ch->io_outstanding++;

		shared_resource->io_outstanding++;

		bdev_io->internal.in_submit_request = true;

		bdev->fn_table->submit_request(ch->channel, bdev_io);

		bdev_io->internal.in_submit_request = false;

		submitted_ios++;

	}