Commit eacc9199 authored by Weifeng Su's avatar Weifeng Su Committed by Tomasz Zawadzki
Browse files

lib/nvme: Add error handler for parse_event 



Add handler for 'strstr, strrchr' function in 'NULL' return
that maybe cause memory access issue.

Signed-off-by: default avatarWeifeng Su <suweifeng1@huawei.com>
Signed-off-by: default avatarShihao Sun <sunshihao@huawei.com>
Change-Id: I2525fbcd9f8ce0a78383305c735b2d27575f4bfe
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5071


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent d73077b8

lib/nvme/nvme_uevent.c

+8 −1
Original line number Diff line number Diff line
@@ -135,10 +135,17 @@ parse_event(const char *buf, struct spdk_uevent *event) 
			event->action = SPDK_NVME_UEVENT_REMOVE;

		}

		tmp = strstr(dev_path, "/uio/");



		if (!tmp) {

			SPDK_ERRLOG("Invalid format of uevent: %s\n", dev_path);

			return -1;

		}

		memset(tmp, 0, SPDK_UEVENT_MSG_LEN - (tmp - dev_path));



		pci_address = strrchr(dev_path, '/');

		if (!pci_address) {

			SPDK_ERRLOG("Not found NVMe BDF in uevent: %s\n", dev_path);

			return -1;

		}

		pci_address++;

		if (spdk_pci_addr_parse(&pci_addr, pci_address) != 0) {

			SPDK_ERRLOG("Invalid format for NVMe BDF: %s\n", pci_address);