Commit eac74709 authored by Pierre Lestringant's avatar Pierre Lestringant Committed by Tomasz Zawadzki
Browse files

test/unit: remove unused stubs 



It seems that these stubs were not used.

Signed-off-by: default avatarPierre Lestringant <plestringant@kalray.eu>
Change-Id: I8ce423ca3448db34be7cdfc1920d53be66b9ca82
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18474


Reviewed-by: default avatarJim Harris <jim.harris@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 1d83144f

test/nvme/cuse/cuse.c

+0 −3
Original line number Diff line number Diff line
@@ -12,9 +12,6 @@ 
DEFINE_STUB(nvme_io_msg_send, int, (struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid,

				    spdk_nvme_io_msg_fn fn, void *arg), 0);



DEFINE_STUB(spdk_nvme_ctrlr_alloc_cmb_io_buffer, void *, (struct spdk_nvme_ctrlr *ctrlr,

		size_t size), NULL);



DEFINE_STUB(spdk_nvme_ctrlr_cmd_admin_raw, int, (struct spdk_nvme_ctrlr *ctrlr,

		struct spdk_nvme_cmd *cmd, void *buf, uint32_t len,

		spdk_nvme_cmd_cb cb_fn, void *cb_arg), 0);

test/unit/lib/event/app.c/app_ut.c

+0 −1
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ DEFINE_STUB_V(spdk_reactors_start, (void)); 
DEFINE_STUB_V(spdk_reactors_stop, (void *arg1));

DEFINE_STUB(spdk_reactors_init, int, (size_t msg_mempool_size), 0);

DEFINE_STUB_V(spdk_reactors_fini, (void));

DEFINE_STUB_V(_spdk_scheduler_set_period, (uint64_t period));

bool g_scheduling_in_progress;



static void

test/unit/lib/ftl/ftl_band.c/ftl_band_ut.c

+0 −7
Original line number Diff line number Diff line
@@ -34,9 +34,6 @@ DEFINE_STUB_V(ftl_p2l_validate_ckpt, (struct ftl_band *band)); 
DEFINE_STUB_V(ftl_trace_limits, (struct spdk_ftl_dev *dev, int limit, size_t num_free));

DEFINE_STUB_V(ftl_trace_completion, (struct spdk_ftl_dev *dev, const struct ftl_io *io,

				     enum ftl_trace_completion completion));

DEFINE_STUB_V(ftl_trace_defrag_band, (struct spdk_ftl_dev *dev, const struct ftl_band *band));

DEFINE_STUB_V(ftl_trace_wbuf_fill, (struct spdk_ftl_dev *dev, const struct ftl_io *io));

DEFINE_STUB_V(ftl_trace_wbuf_pop, (struct spdk_ftl_dev *dev, const struct ftl_wbuf_entry *entry));

DEFINE_STUB_V(ftl_trace_write_band, (struct spdk_ftl_dev *dev, const struct ftl_band *band));

DEFINE_STUB_V(ftl_trace_submission, (struct spdk_ftl_dev *dev, const struct ftl_io *io,

				     ftl_addr addr, size_t addr_cnt));
@@ -69,7 +66,6 @@ DEFINE_STUB_V(ftl_io_complete, (struct ftl_io *io)); 
DEFINE_STUB(ftl_io_current_lba, uint64_t, (const struct ftl_io *io), 0);

DEFINE_STUB_V(ftl_io_dec_req, (struct ftl_io *io));

DEFINE_STUB_V(ftl_io_fail, (struct ftl_io *io, int status));

DEFINE_STUB_V(ftl_io_free, (struct ftl_io *io));

DEFINE_STUB(ftl_io_get_lba, uint64_t,

	    (const struct ftl_io *io, size_t offset), 0);

DEFINE_STUB_V(ftl_io_inc_req, (struct ftl_io *io));
@@ -80,9 +76,6 @@ DEFINE_STUB(ftl_iovec_num_blocks, size_t, 
	    (struct iovec *iov, size_t iov_cnt), 0);

DEFINE_STUB_V(ftl_reloc, (struct ftl_reloc *reloc));



DEFINE_STUB_V(ftl_reloc_add, (struct ftl_reloc *reloc, struct ftl_band *band, size_t offset,

			      size_t num_blocks, int prio, bool defrag));

DEFINE_STUB(ftl_reloc_is_defrag_active, bool, (const struct ftl_reloc *reloc), false);

DEFINE_STUB(ftl_reloc_is_halted, bool, (const struct ftl_reloc *reloc), false);

DEFINE_STUB_V(ftl_reloc_halt, (struct ftl_reloc *reloc));

DEFINE_STUB(spdk_bdev_is_zoned, bool, (const struct spdk_bdev *bdev), true);

test/unit/lib/ftl/ftl_io.c/ftl_io_ut.c

+0 −6
Original line number Diff line number Diff line
@@ -60,12 +60,9 @@ DEFINE_STUB(spdk_mempool_create_ctor, struct spdk_mempool *, 
DEFINE_STUB(spdk_mempool_obj_iter, uint32_t,

	    (struct spdk_mempool *mp, spdk_mempool_obj_cb_t obj_cb, void *obj_cb_arg), 0);

DEFINE_STUB_V(ftl_reloc, (struct ftl_reloc *reloc));

DEFINE_STUB_V(ftl_reloc_add, (struct ftl_reloc *reloc, struct ftl_band *band, size_t offset,

			      size_t num_blocks, int prio, bool defrag));

DEFINE_STUB_V(ftl_reloc_free, (struct ftl_reloc *reloc));

DEFINE_STUB_V(ftl_reloc_halt, (struct ftl_reloc *reloc));

DEFINE_STUB(ftl_reloc_init, struct ftl_reloc *, (struct spdk_ftl_dev *dev), NULL);

DEFINE_STUB(ftl_reloc_is_defrag_active, bool, (const struct ftl_reloc *reloc), false);

DEFINE_STUB(ftl_reloc_is_halted, bool, (const struct ftl_reloc *reloc), false);

DEFINE_STUB_V(ftl_reloc_resume, (struct ftl_reloc *reloc));

DEFINE_STUB_V(ftl_l2p_unpin, (struct spdk_ftl_dev *dev, uint64_t lba, uint64_t count));
@@ -75,7 +72,6 @@ DEFINE_STUB(ftl_l2p_get, ftl_addr, (struct spdk_ftl_dev *dev, uint64_t lba), 0); 
DEFINE_STUB_V(ftl_mempool_put, (struct ftl_mempool *mpool, void *element));



#if defined(DEBUG)

DEFINE_STUB_V(ftl_trace_defrag_band, (struct spdk_ftl_dev *dev, const struct ftl_band *band));

DEFINE_STUB_V(ftl_trace_submission, (struct spdk_ftl_dev *dev, const struct ftl_io *io,

				     ftl_addr addr, size_t addr_cnt));

DEFINE_STUB_V(ftl_trace_lba_io_init, (struct spdk_ftl_dev *dev, const struct ftl_io *io));
@@ -83,8 +79,6 @@ DEFINE_STUB_V(ftl_trace_limits, (struct spdk_ftl_dev *dev, int limit, size_t num 
DEFINE_STUB(ftl_trace_alloc_id, uint64_t, (struct spdk_ftl_dev *dev), 0);

DEFINE_STUB_V(ftl_trace_completion, (struct spdk_ftl_dev *dev, const struct ftl_io *io,

				     enum ftl_trace_completion type));

DEFINE_STUB_V(ftl_trace_wbuf_fill, (struct spdk_ftl_dev *dev, const struct ftl_io *io));

DEFINE_STUB_V(ftl_trace_wbuf_pop, (struct spdk_ftl_dev *dev, const struct ftl_wbuf_entry *entry));

DEFINE_STUB_V(ftl_trace_write_band, (struct spdk_ftl_dev *dev, const struct ftl_band *band));

#endif

test/unit/lib/iscsi/conn.c/conn_ut.c

+0 −5
Original line number Diff line number Diff line
@@ -189,8 +189,6 @@ DEFINE_STUB_V(iscsi_task_response, 
DEFINE_STUB_V(iscsi_task_mgmt_response,

	      (struct spdk_iscsi_conn *conn, struct spdk_iscsi_task *task));



DEFINE_STUB_V(iscsi_send_nopin, (struct spdk_iscsi_conn *conn));



bool

iscsi_del_transfer_task(struct spdk_iscsi_conn *conn, uint32_t task_tag)

{
@@ -219,9 +217,6 @@ DEFINE_STUB(iscsi_tgt_node_cleanup_luns, int, 
DEFINE_STUB(iscsi_pdu_calc_header_digest, uint32_t,

	    (struct spdk_iscsi_pdu *pdu), 0);



DEFINE_STUB(spdk_iscsi_pdu_calc_data_digest, uint32_t,

	    (struct spdk_iscsi_pdu *pdu), 0);



DEFINE_STUB_V(shutdown_iscsi_conns_done, (void));



static struct spdk_iscsi_task *