Commit ea8aa1bf authored Dec 13, 2018 by Ziye Yang Committed by Jim Harris Dec 13, 2018

nvmf: check the qpair->ctrlr



The ctrlr may be NULL, so we need to add a check here
to present segment fault.

Change-Id: I6c5361cc829af065082a95df0b8cc2f8d49a6002
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.gerrithub.io/436950


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Maciej Szwed <maciej.szwed@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

parent 35f401ad

lib/nvmf/nvmf.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1022,7 +1022,7 @@ _nvmf_subsystem_disconnect_next_qpair(void *ctx)
		subsystem = qpair_ctx->subsystem;

		TAILQ_FOREACH(qpair, &group->qpairs, link) {
		if (qpair->ctrlr->subsys == subsystem) {
		if ((qpair->ctrlr != NULL) && (qpair->ctrlr->subsys == subsystem)) {
		break;
		}
		}
		@@ -1063,7 +1063,7 @@ spdk_nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group,
		sgroup->state = SPDK_NVMF_SUBSYSTEM_INACTIVE;

		TAILQ_FOREACH(qpair, &group->qpairs, link) {
		if (qpair->ctrlr->subsys == subsystem) {
		if ((qpair->ctrlr != NULL) && (qpair->ctrlr->subsys == subsystem)) {
		break;
		}
		}