Commit ea2000cf authored by Vitaliy Mysak's avatar Vitaliy Mysak Committed by Tomasz Zawadzki
Browse files

event: disable cpumask check 



cpumask can be changed by spdk_thread_set_cpumask()
during the time that event takes before it arrives
on _schedule_thread() function, which would make the
function assert(false), even though that is ~ok~.

Currently, that can happen right after thread is created
or between two successive calls to spdk_thread_set_cpumask().
But most importantly, it will constantly happen if we
introduce rescheduler.

This patch just disables the check for now.

Change-Id: Ie6dfe22d6eff2c908c367d1311436cc6769a6960
Signed-off-by: default avatarVitaliy Mysak <vitaliy.mysak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3905


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 767df128

lib/event/reactor.c

+0 −9
Original line number Diff line number Diff line
@@ -494,20 +494,11 @@ static void 
_schedule_thread(void *arg1, void *arg2)

{

	struct spdk_lw_thread *lw_thread = arg1;

	struct spdk_thread *thread;

	struct spdk_cpuset *cpumask;

	struct spdk_reactor *reactor;

	uint32_t current_core;



	current_core = spdk_env_get_current_core();



	thread = spdk_thread_get_from_ctx(lw_thread);

	cpumask = spdk_thread_get_cpumask(thread);

	if (!spdk_cpuset_get_cpu(cpumask, current_core)) {

		SPDK_ERRLOG("Thread was scheduled to the wrong core %d\n", current_core);

		assert(false);

	}



	reactor = spdk_reactor_get(current_core);

	assert(reactor != NULL);