Commit e9a42847 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

env, env_dpdk: remove deprecated get_socket_id() APIs 



Signed-off-by: default avatarJim Harris <jim.harris@nvidia.com>
Change-Id: Icfbb5713f9572d9b6d7655591c1e0791f76fe83f
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26446


Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent 7475fdc3

deprecation.md

+0 −7
Original line number Diff line number Diff line
@@ -55,13 +55,6 @@ See GitHub issue [2801](https://github.com/spdk/spdk/issues/2801) for additional 
New SPDK partition types should use GUID `6527994e-2c5a-4eec-9613-8f5944074e8b` which will create

a bdev of the correct size.



### env



#### `spdk_env_get_socket_id`, `spdk_pci_device_get_socket_id`



These functions are deprecated and will be removed in 25.09 release. Please use

`spdk_env_get_numa_id` and `spdk_pci_device_get_numa_id` instead.



### reduce



#### 'spdk_reduce_vol_init', 'spdk_reduce_vol_load'

include/spdk/env.h

+0 −22
Original line number Diff line number Diff line
@@ -518,17 +518,6 @@ uint32_t spdk_env_get_next_core(uint32_t prev_core); 
 */

int32_t spdk_env_get_numa_id(uint32_t core);



/**

 * Get the NUMA node ID for the given core.

 *

 * Deprecated, use \ref spdk_env_get_numa_id() instead.

 *

 * \param core CPU core to query.

 *

 * \return the NUMA node ID for the given core.

 */

uint32_t spdk_env_get_socket_id(uint32_t core);



/**

 * Get the ID of the first NUMA node on this system.

 *
@@ -1076,17 +1065,6 @@ struct spdk_pci_id spdk_pci_device_get_id(struct spdk_pci_device *dev); 
 */

int spdk_pci_device_get_numa_id(struct spdk_pci_device *dev);



/**

 * Get the NUMA node the PCI device is on.

 *

 * Deprecated. Use `ref spdk_pci_device_get_numa_id()` instead.

 *

 * \param dev PCI device.

 *

 * \return NUMA node index (>= 0).

 */

int spdk_pci_device_get_socket_id(struct spdk_pci_device *dev);



/**

 * Serialize the PCIe Device Serial Number into the provided buffer.

 * The buffer will contain a 16-character-long serial number followed by

lib/env_dpdk/pci.c

+0 −9
Original line number Diff line number Diff line
@@ -938,15 +938,6 @@ spdk_pci_device_get_numa_id(struct spdk_pci_device *dev) 
	return dev->numa_id;

}



SPDK_LOG_DEPRECATION_REGISTER(pci_device_socket_id, "spdk_pci_device_get_socket_id", "v25.09", 0);



int

spdk_pci_device_get_socket_id(struct spdk_pci_device *dev)

{

	SPDK_LOG_DEPRECATED(pci_device_socket_id);

	return spdk_pci_device_get_numa_id(dev);

}



int

spdk_pci_device_cfg_read(struct spdk_pci_device *dev, void *value, uint32_t len, uint32_t offset)

{

lib/env_dpdk/spdk_env_dpdk.map

+0 −2
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ 
	spdk_env_get_first_core;

	spdk_env_get_last_core;

	spdk_env_get_next_core;

	spdk_env_get_socket_id;

	spdk_env_get_numa_id;

	spdk_env_get_first_numa_id;

	spdk_env_get_last_numa_id;
@@ -86,7 +85,6 @@ 
	spdk_pci_device_get_subvendor_id;

	spdk_pci_device_get_subdevice_id;

	spdk_pci_device_get_id;

	spdk_pci_device_get_socket_id;

	spdk_pci_device_get_numa_id;

	spdk_pci_device_get_serial_number;

	spdk_pci_device_claim;

lib/env_dpdk/threads.c

+0 −9
Original line number Diff line number Diff line
@@ -76,15 +76,6 @@ spdk_env_get_numa_id(uint32_t core) 
	return rte_lcore_to_socket_id(core);

}



SPDK_LOG_DEPRECATION_REGISTER(env_socket_id, "spdk_env_get_socket_id", "v25.09", 0);



uint32_t

spdk_env_get_socket_id(uint32_t core)

{

	SPDK_LOG_DEPRECATED(env_socket_id);

	return spdk_env_get_numa_id(core);

}



int32_t

spdk_env_get_first_numa_id(void)

{