Commit e93ba047 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

nvme: Restore complete_abort_queued_reqs() call into process_completions() 

spdk_nvme_qpair_process_completions() had called
always _nvme_qpair_complete_abort_queued_reqs() at its end.

However, the call was accidentally removed by a commit
https://github.com/spdk/spdk/commit/59c8bb527b98301fedfd5445874bbcc59bc5bb67


to fix an issue.

By this removal, aborting request was not completed for some error
cases.

Fix the degradation by restoring the call.

Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I0099eb7a008f823e1282576504423cdc248911d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14045


Reviewed-by: default avatarMichael Haeuptle <michaelhaeuptle@gmail.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent bde5d09b

lib/nvme/nvme_qpair.c

+2 −0
Original line number Diff line number Diff line
@@ -761,6 +761,8 @@ spdk_nvme_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_ 
	 */

	if (ret > 0) {

		nvme_qpair_resubmit_requests(qpair, ret);

	} else {

		_nvme_qpair_complete_abort_queued_reqs(qpair);

	}



	return ret;