Commit e8c73275 authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

test/iscsi: In ip_migration.sh, don't run both targets on the same core 



This fixes a 3+ year old TODO

Change-Id: I2516586d120b0f6f8d3d0fc54a5ebdd93aae6bc2
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4300


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 4eec3651

test/iscsi_tgt/ip_migration/ip_migration.sh

+4 −3
Original line number Diff line number Diff line
@@ -76,9 +76,9 @@ function rpc_add_target_node() { 


function iscsi_tgt_start() {

	# $1 = RPC server address

	# $2 = Core Mask



	# TODO: run the different iSCSI instances on non-overlapping CPU masks

	"${ISCSI_APP[@]}" -r $1 -m $ISCSI_TEST_CORE_MASK --wait-for-rpc &

	"${ISCSI_APP[@]}" -r $1 -m $2 --wait-for-rpc &

	pid=$!

	echo "Process pid: $pid"
@@ -99,8 +99,9 @@ for ((i = 0; i < 2; i++)); do 
	timing_enter start_iscsi_tgt_$i



	rpc_addr="/var/tmp/spdk${i}.sock"

	mask=$((1 << i))



	iscsi_tgt_start $rpc_addr

	iscsi_tgt_start $rpc_addr $mask



	timing_exit start_iscsi_tgt_$i

done