Commit e685574f authored by Weiguo Li's avatar Weiguo Li Committed by Jim Harris
Browse files

iscsi: fix a memory leak in error handling 



When function returned from the error handling the mempool on
'sess' was not released which lead to a memory leak.

Fixes issue #2393.

Signed-off-by: default avatarWeiguo Li <liwg06@foxmail.com>
Change-Id: Ida3651e9369fb5c4948969480d398a723b2cb6a2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11714


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
parent 30af49f7

lib/iscsi/iscsi.c

+1 −0
Original line number Diff line number Diff line
@@ -582,6 +582,7 @@ create_iscsi_sess(struct spdk_iscsi_conn *conn, 


	sess->conns = calloc(sess->MaxConnections, sizeof(*sess->conns));

	if (!sess->conns) {

		spdk_mempool_put(g_iscsi.session_pool, (void *)sess);

		SPDK_ERRLOG("calloc() failed for connection array\n");

		return -ENOMEM;

	}