Commit e655d178 authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

nvmf: rename function that detects last_wqe_reached 



Use "nvmf_rdma_device_supports_last_wqe_reached". This makes it more
clear that for iWARP/SoftRoCE we aren't ignoring "last_wqe_reached",
but rather we can ignore the fact that we won't received this event
for those devices.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I05103e17fe0a05b3738e2e7c4e97ec984f110fc8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24981


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
parent 982c2051

lib/nvmf/rdma.c

+7 −4
Original line number Diff line number Diff line
@@ -3424,11 +3424,11 @@ nvmf_rdma_poller_process_pending_buf_queue(struct spdk_nvmf_rdma_transport *rtra 
}



static inline bool

nvmf_rdma_can_ignore_last_wqe_reached(struct spdk_nvmf_rdma_device *device)

nvmf_rdma_device_supports_last_wqe_reached(struct spdk_nvmf_rdma_device *device)

{

	/* iWARP transport and SoftRoCE driver don't support LAST_WQE_REACHED ibv async event */

	return nvmf_rdma_is_rxe_device(device) ||

	       device->context->device->transport_type == IBV_TRANSPORT_IWARP;

	return !nvmf_rdma_is_rxe_device(device) &&

	       device->context->device->transport_type != IBV_TRANSPORT_IWARP;

}



static void
@@ -3459,8 +3459,11 @@ nvmf_rdma_destroy_drained_qpair(struct spdk_nvmf_rdma_qpair *rqpair) 
		return;

	}



	/* For devices that support LAST_WQE_REACHED with srq, we need to

	 * wait to destroy the qpair until that event has been received.

	 */

	if (rqpair->srq != NULL && rqpair->last_wqe_reached == false &&

	    !nvmf_rdma_can_ignore_last_wqe_reached(rqpair->device)) {

	    nvmf_rdma_device_supports_last_wqe_reached(rqpair->device)) {

		return;

	}