Commit e5108dfa authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

lib/iscsi: Fix the issue that the array of connections is not invalidated 



In iscsi_conns_cleanup(), g_conns_array was unmapped but was not
invalidated by setting MAP_FAILED.

So, find_iscsi_connection_by_id() caused segmentation fault if
it is called after iscsi_conns_cleanup().

Change-Id: Ib91c9240c62c2aaa32713dd4aa382d31e5ea2eed
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450901


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 766c5361

lib/iscsi/conn.c

+1 −0
Original line number Diff line number Diff line
@@ -607,6 +607,7 @@ iscsi_conns_cleanup(void) 
	free(g_num_connections);

	munmap(g_conns_array, sizeof(struct spdk_iscsi_conn) *

	       MAX_ISCSI_CONNECTIONS);

	g_conns_array = MAP_FAILED;

	shm_unlink(g_shm_name);

	if (g_conns_array_fd >= 0) {

		close(g_conns_array_fd);