Commit e4febd9c authored by Vasilii Ivanov's avatar Vasilii Ivanov Committed by Tomasz Zawadzki
Browse files

bdev: change histogram default min and max value 



After introducing API to set histogram min and max value
we can change default values for bdev histogram to more reasonable
values. Now default range is from 1us to 120s.

Change-Id: I959a4ce4f0fa95063cfc69fa90af940b7d4f5665
Signed-off-by: default avatarVasilii Ivanov <iwanovvvasilij@gmail.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26393


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent 2002cace

doc/jsonrpc.md

+2 −2
Original line number Diff line number Diff line
@@ -2817,8 +2817,8 @@ Control whether collecting data for histogram is enabled for specified bdev. 
 enable      | Required   | boolean | Enable or disable histogram on specified device

 opc         | Optional   | string  | IO type name

 granularity | Optional   | number  | Histogram bucket granularity. Default: 7

 min_nsec    | Optional   | number  | Min value in nanoseconds to track. Default: 0

 max_nsec    | Optional   | number  | Max value in nanoseconds to track. Default: UINT64_T (max possible value)

 min_nsec    | Optional   | number  | Min value in nanoseconds to track. Default: 1000 (1us)

 max_nsec    | Optional   | number  | Max value in nanoseconds to track. Default: 120000000000 (120 seconds)



#### Example

lib/bdev/bdev_rpc.c

+5 −2
Original line number Diff line number Diff line
@@ -18,6 +18,9 @@ 


#include "bdev_internal.h"



#define SPDK_BDEV_HISTOGRAM_DEFAULT_MIN_VALUE_NS (1000)

#define SPDK_BDEV_HISTOGRAM_DEFAULT_MAX_VALUE_NS (120000000000)



static void

dummy_bdev_event_cb(enum spdk_bdev_event_type type, struct spdk_bdev *bdev, void *ctx)

{
@@ -1029,8 +1032,8 @@ rpc_bdev_enable_histogram(struct spdk_jsonrpc_request *request, 
			  const struct spdk_json_val *params)

{

	struct rpc_bdev_enable_histogram_request req = {.granularity = SPDK_HISTOGRAM_GRANULARITY_DEFAULT,

		       .min_nsec = 0,

		       .max_nsec = UINT64_MAX

		       .min_nsec = SPDK_BDEV_HISTOGRAM_DEFAULT_MIN_VALUE_NS,

		       .max_nsec = SPDK_BDEV_HISTOGRAM_DEFAULT_MAX_VALUE_NS

	};

	struct spdk_bdev_desc *desc;

	int rc;