Commit e358eaee authored May 10, 2019 by GangCao Committed by Changpeng Liu May 13, 2019

iscsi: fix double free when failed to start target



When iSCSI target failed to start due to insuccificent resource like PDU pool,
one memory is double freed.

Change-Id: I1b68d4f0f130b024be9f8406c8d1611e92a27787
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453981


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: wuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

parent 9602ade7

lib/iscsi/iscsi_subsystem.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1308,6 +1308,7 @@ iscsi_parse_globals(void)
		if (rc != 0) {
		SPDK_ERRLOG("spdk_initialize_all_pools() failed\n");
		free(g_spdk_iscsi.session);
		g_spdk_iscsi.session = NULL;
		return -1;
		}

		@@ -1315,6 +1316,7 @@ iscsi_parse_globals(void)
		if (rc < 0) {
		SPDK_ERRLOG("spdk_initialize_iscsi_conns() failed\n");
		free(g_spdk_iscsi.session);
		g_spdk_iscsi.session = NULL;
		return rc;
		}