Commit e2ce08cf authored Aug 23, 2019 by Tomasz Zawadzki Committed by Jim Harris Aug 23, 2019

ut/bdev: fix scan-build reporting uninitalized values



Scan-build on Fedora29/30 reports error, which this patch fixes:
bdev_ut.c:1436:17: warning: The left operand of '!=' is a garbage value
CU_ASSERT(desc != NULL);
~~~~ ^
/usr/include/CUnit/CUnit.h:123:30: note: expanded from macro 'CU_ASSERT'
{ CU_assertImplementation((value), LINE, #value, FILE, "", CU_FALSE); }
^~~~~
bdev_ut.c:1654:17: warning: The left operand of '!=' is a garbage value
CU_ASSERT(desc != NULL);
~~~~ ^
/usr/include/CUnit/CUnit.h:123:30: note: expanded from macro 'CU_ASSERT'
{ CU_assertImplementation((value), LINE, #value, FILE, "", CU_FALSE); }

Fixes #924

Change-Id: Ia7dc6ce066ac80fc45f022eefd43a224d2f11503
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466110


Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent fd0f0364

test/unit/lib/bdev/bdev.c/bdev_ut.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1412,7 +1412,7 @@ static void
		bdev_io_alignment(void)
		{
		struct spdk_bdev *bdev;
		struct spdk_bdev_desc *desc;
		struct spdk_bdev_desc *desc = NULL;
		struct spdk_io_channel *io_ch;
		struct spdk_bdev_opts bdev_opts = {
		.bdev_io_pool_size = 20,
		@@ -1630,7 +1630,7 @@ static void
		bdev_io_alignment_with_boundary(void)
		{
		struct spdk_bdev *bdev;
		struct spdk_bdev_desc *desc;
		struct spdk_bdev_desc *desc = NULL;
		struct spdk_io_channel *io_ch;
		struct spdk_bdev_opts bdev_opts = {
		.bdev_io_pool_size = 20,