Commit e1accdca authored by Dariusz Stojaczyk's avatar Dariusz Stojaczyk Committed by Jim Harris
Browse files

ut/vhost: remove test case `Remove device with too long name and path` 



This was originally introduced to improve
code coverage in vhost_dev_unregister() where
we used to check against buffer overflow. But
the check has been removed long ago. The vdev
socket path string is validated only on device
registration.

The test case is being removed because it
conflicts with upcoming changes. Rather than
trying to refactor and fix it, let's remove it
- it's no longer needed.

Change-Id: I3bac15725e94b38d375db6376bea4a7b1e44d75c
Signed-off-by: default avatarDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/399441


Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent ea6c2709

test/unit/lib/vhost/vhost.c/vhost_ut.c

+0 −18
Original line number Diff line number Diff line
@@ -278,7 +278,6 @@ static void 
remove_controller_test(void)

{

	struct spdk_vhost_dev *vdev;

	char long_name[PATH_MAX];

	int ret;



	vdev = alloc_vdev();
@@ -296,25 +295,8 @@ remove_controller_test(void) 
	vdev->lcore = -1;

	ret = spdk_vhost_dev_unregister(vdev);

	CU_ASSERT(ret != 0);

	if (ret != 0) {

		free(vdev->name);

	}



	/* Remove device with too long name and path */

	memset(long_name, 'x', sizeof(long_name));

	long_name[PATH_MAX - 1] = 0;

	snprintf(dev_dirname, sizeof(dev_dirname), "some_path/");

	vdev->name = strdup(long_name);

	g_spdk_vhost_devices[0] = vdev;

	ret = spdk_vhost_dev_unregister(vdev);

	CU_ASSERT(ret != 0);

	if (ret == 0) {

		vdev->name = NULL;

	}



	free_vdev(vdev);

	g_spdk_vhost_devices[0] = NULL;

	dev_dirname[0] = 0;

}



int