Commit e1946cd7 authored Aug 03, 2021 by Michal Berger Committed by Jim Harris Aug 04, 2021

test/common: Add SERIAL to the last check in waitforserial_disconnect()



The argument is meant to be SERIAL so the last check may erroneously
force waitforserial_disconnect() to report success if lsblk is not told
to include serial of the device in the output.

Signed-off-by: Michal Berger <michalx.berger@intel.com>
Change-Id: Iee591597140658b1e611a84e65b280c565eecdfc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9057


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 6434aaa2

test/common/autotest_common.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -1056,7 +1056,7 @@ function waitforserial_disconnect() {
		sleep 1
		done

		if lsblk -l -o NAME \| grep -q -w $1; then
		if lsblk -l -o NAME,SERIAL \| grep -q -w $1; then
		return 1
		fi