Commit e15a704e authored Nov 23, 2016 by Daniel Verkamp

nvme/rdma: fix nvme_rdma_qpair_destroy() NULL check



Verify that qpair is not NULL before doing pointer math on it.
The NULL check after calling nvme_rdma_qpair(qpair) would not
trigger if qpair was NULL.

Fixes a crash if the Connect command failed, causing
nvme_rdma_ctrlr_create_qpair() to return NULL.

Change-Id: I158a5b1752892a7d5a72a9ac20c0c5b2cd781a81
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>

parent 648c15d1

lib/nvme/nvme_rdma.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1035,11 +1035,12 @@ nvme_rdma_qpair_destroy(struct spdk_nvme_qpair *qpair)
		{
		struct nvme_rdma_qpair *rqpair;

		rqpair = nvme_rdma_qpair(qpair);
		if (!rqpair) {
		if (!qpair) {
		return -1;
		}

		rqpair = nvme_rdma_qpair(qpair);

		nvme_rdma_free_reqs(rqpair);
		nvme_rdma_free_rsps(rqpair);