Commit dd7140e6 authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

accel: Rename spdk_accel_engine_module_finish to 


spdk_accel_module_finish

Also move it into the internal header that defines the interface used by
modules.

Change-Id: I3aeb41e643f27a69556099cb8d166f64c9e5d67f
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13917


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
parent 0b9ba6a3

include/spdk/accel.h

+0 −5
Original line number Diff line number Diff line
@@ -61,11 +61,6 @@ int spdk_accel_engine_initialize(void); 
 */

void spdk_accel_engine_finish(spdk_accel_fini_cb cb_fn, void *cb_arg);



/**

 * Close the acceleration engine module and perform any necessary cleanup.

 */

void spdk_accel_engine_module_finish(void);



/**

 * Get the I/O channel registered on the acceleration engine.

 *

include/spdk_internal/accel_engine.h

+5 −0
Original line number Diff line number Diff line
@@ -89,4 +89,9 @@ static void __attribute__((constructor)) _spdk_accel_module_register_##name(void 
	spdk_accel_module_list_add(module); \

}



/**

 * Called by an accel module when cleanup initiated during .module_fini has completed

 */

void spdk_accel_module_finish(void);



#endif

lib/accel/accel_engine.c

+3 −3
Original line number Diff line number Diff line
@@ -637,7 +637,7 @@ spdk_accel_write_config_json(struct spdk_json_write_ctx *w) 
}



void

spdk_accel_engine_module_finish(void)

spdk_accel_module_finish(void)

{

	if (!g_accel_engine_module) {

		g_accel_engine_module = TAILQ_FIRST(&spdk_accel_module_list);
@@ -653,7 +653,7 @@ spdk_accel_engine_module_finish(void) 
	if (g_accel_engine_module->module_fini) {

		spdk_thread_send_msg(spdk_get_thread(), g_accel_engine_module->module_fini, NULL);

	} else {

		spdk_accel_engine_module_finish();

		spdk_accel_module_finish();

	}

}
@@ -676,7 +676,7 @@ spdk_accel_engine_finish(spdk_accel_fini_cb cb_fn, void *cb_arg) 
	}



	spdk_io_device_unregister(&spdk_accel_module_list, NULL);

	spdk_accel_engine_module_finish();

	spdk_accel_module_finish();

}



SPDK_LOG_REGISTER_COMPONENT(accel)

lib/accel/accel_sw.c

+1 −1
Original line number Diff line number Diff line
@@ -385,7 +385,7 @@ static void 
sw_accel_engine_fini(void *ctxt)

{

	spdk_io_device_unregister(&g_sw_module, NULL);

	spdk_accel_engine_module_finish();

	spdk_accel_module_finish();

}



SPDK_ACCEL_MODULE_REGISTER(sw, &g_sw_module)

lib/accel/spdk_accel.map

+1 −1
Original line number Diff line number Diff line
@@ -4,7 +4,6 @@ 
	# public functions

	spdk_accel_engine_initialize;

	spdk_accel_engine_finish;

	spdk_accel_engine_module_finish;

	spdk_accel_engine_get_io_channel;

	spdk_accel_submit_copy;

	spdk_accel_submit_dualcast;
@@ -22,6 +21,7 @@ 


	# functions needed by modules

	spdk_accel_module_list_add;

	spdk_accel_module_finish;

	spdk_accel_task_complete;



	local: *;