Commit dd2b935d authored by Michal Berger's avatar Michal Berger Committed by Jim Harris
Browse files

check_format: Fixes for shellcheck's SC2268 directive 



SC2268: Avoid x-prefix in comparisons as it no longer serves a purpose

Signed-off-by: default avatarMichal Berger <michalx.berger@intel.com>
Change-Id: Ica5ddfa8c39f34741c7344906abe802ff7451b1f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8505


Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatar <tomasz.rochumski@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 742f04b3

test/vhost/fiotest/fio.sh

+1 −1
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ rpc_py="$rootdir/scripts/rpc.py -s $(get_vhost_dir 0)/rpc.sock" 


for vm_conf in "${vms[@]}"; do

	IFS=',' read -ra conf <<< "$vm_conf"

	if [[ x"${conf[0]}" == x"" ]] || ! assert_number ${conf[0]}; then

	if [[ -z ${conf[0]} ]] || ! assert_number ${conf[0]}; then

		fail "invalid VM configuration syntax $vm_conf"

	fi

test/vhost/hotplug/common.sh

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ function print_test_fio_header() { 
function vms_setup() {

	for vm_conf in "${vms[@]}"; do

		IFS=',' read -ra conf <<< "$vm_conf"

		if [[ x"${conf[0]}" == x"" ]] || ! assert_number ${conf[0]}; then

		if [[ -z ${conf[0]} ]] || ! assert_number ${conf[0]}; then

			fail "invalid VM configuration syntax $vm_conf"

		fi