Commit dbf2510a authored by Fedor Uporov's avatar Fedor Uporov Committed by Jim Harris
Browse files

util/net: check the getifaddrs() function return value 



The getifaddrs() can silently failed, what will cause uninitialised
pointer dereference.

Change-Id: Ia248eeb6444129dadf5d49aee8aff33c567635b9
Signed-off-by: default avatarFedor Uporov <fuporov.vstack@gmail.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26158


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
parent 9678f39f

lib/util/net.c

+5 −1
Original line number Diff line number Diff line
@@ -91,7 +91,11 @@ spdk_net_is_loopback(int fd) 
		return is_loopback;

	}



	getifaddrs(&addrs);

	rc = getifaddrs(&addrs);

	if (rc != 0) {

		return is_loopback;

	}



	for (tmp = addrs; tmp != NULL; tmp = tmp->ifa_next) {

		if (tmp->ifa_addr && (tmp->ifa_flags & IFF_UP) &&

		    (tmp->ifa_addr->sa_family == sa.ss_family)) {