Commit db331d80 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

vmd: fix comments around resetting root ports 



Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I169cef4b795dc5c3910140e9b4111958352731db
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20188


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent f0b52280

lib/vmd/vmd.c

+4 −4
Original line number Diff line number Diff line
@@ -1108,10 +1108,10 @@ vmd_reset_root_ports(struct vmd_pci_bus *bus) 


	/*

	 * The root ports might have been configured by some other driver (e.g.  Linux kernel) prior

	 * to loading the SPDK one, so we need to clear it.  We need to before the scanning process,

	 * as it's depth-first, so when scanning the initial root ports, the latter ones might still

	 * be using stale configuration.  This can lead to two bridges having the same

	 * secondary/subordinate bus configuration, which, of course, isn't correct.

	 * to loading the SPDK one, so we need to clear it.  We need to do it before starting the

	 * scanning process, as it's depth-first, so when initial root ports are scanned, the

	 * latter ones might still be using stale configuration.  This can lead to two bridges

	 * having the same secondary/subordinate bus configuration, which, of course, isn't correct.

	 * (Note: this fixed issue #2413.)

	 */

	for (devfn = 0; devfn < 32; ++devfn) {