Commit d9f9e265 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

sock/posix: Implement recv_next 



This is very easy to do - just grab a buffer and receive into it.

Change-Id: Iaf660977caf536df8fcce37d87693cf873582b7c
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16107


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent 784b3b89

module/sock/posix/posix.c

+25 −3
Original line number Diff line number Diff line
@@ -1539,12 +1539,34 @@ posix_sock_writev(struct spdk_sock *_sock, struct iovec *iov, int iovcnt) 
}



static int

posix_sock_recv_next(struct spdk_sock *sock, void **buf, void **ctx)

posix_sock_recv_next(struct spdk_sock *_sock, void **buf, void **ctx)

{

	struct spdk_posix_sock *sock = __posix_sock(_sock);

	struct iovec iov;

	ssize_t rc;



	if (sock->recv_pipe != NULL) {

		errno = ENOTSUP;

		return -1;

	}



	iov.iov_len = spdk_sock_group_get_buf(_sock->group_impl->group, &iov.iov_base, ctx);

	if (iov.iov_len == 0) {

		errno = ENOBUFS;

		return -1;

	}



	rc = posix_sock_readv(_sock, &iov, 1);

	if (rc <= 0) {

		spdk_sock_group_provide_buf(_sock->group_impl->group, iov.iov_base, iov.iov_len, *ctx);

		return rc;

	}



	*buf = iov.iov_base;



	return rc;

}



static void

posix_sock_writev_async(struct spdk_sock *sock, struct spdk_sock_request *req)

{

test/unit/lib/sock/posix.c/posix_ut.c

+4 −0
Original line number Diff line number Diff line
@@ -23,6 +23,10 @@ DEFINE_STUB_V(spdk_sock_map_cleanup, (struct spdk_sock_map *map)); 


DEFINE_STUB_V(spdk_net_impl_register, (struct spdk_net_impl *impl, int priority));

DEFINE_STUB(spdk_sock_close, int, (struct spdk_sock **s), 0);

DEFINE_STUB(spdk_sock_group_provide_buf, int, (struct spdk_sock_group *group, void *buf,

		size_t len, void *ctx), 0);

DEFINE_STUB(spdk_sock_group_get_buf, size_t, (struct spdk_sock_group *group, void **buf,

		void **ctx), 0);



static void

_req_cb(void *cb_arg, int len)